Page MenuHomeFreeBSD

New port: audio/fluidplug-lv2: SoundFonts as LV2 plugins via FluidSynth
ClosedPublic

Authored by yuri on Nov 25 2017, 6:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 10:18 PM
Unknown Object (File)
Wed, Mar 13, 6:00 PM
Unknown Object (File)
Wed, Mar 13, 5:50 PM
Unknown Object (File)
Wed, Mar 13, 5:50 PM
Unknown Object (File)
Wed, Mar 13, 5:50 PM
Unknown Object (File)
Wed, Mar 13, 5:50 PM
Unknown Object (File)
Wed, Mar 13, 5:50 PM
Unknown Object (File)
Wed, Mar 13, 5:50 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13049
Build 13302: arc lint + arc unit

Event Timeline

audio/fluidplug-lv2/Makefile
16

^ new port: sort :)

yuri marked an inline comment as done.Nov 25 2017, 9:41 AM
audio/fluidplug-lv2/Makefile.list
26

^ close one, let's hope they don't add two more :D

Replaced the repetitious statements with for clauses.

yuri marked an inline comment as done.Nov 25 2017, 8:57 PM
mat requested changes to this revision.Nov 27 2017, 1:30 PM
mat added inline comments.
audio/fluidplug-lv2/Makefile
24

Default, remove.

audio/fluidplug-lv2/Makefile.list
4–6

First, this is better written as:

MASTER_SITES+= http://download.linuxaudio.org/musical-instrument-libraries/sf2/AVL-Drumkits-1.1-SF2-splitted/:b,c,d,e,f,g

Second, this is better written as simply :b (or some other group with a more descriptive name) and use :b for all the distfiles that need this particular directory.

This revision now requires changes to proceed.Nov 27 2017, 1:30 PM
yuri marked an inline comment as done.

.

yuri marked an inline comment as done.Nov 27 2017, 5:32 PM
audio/fluidplug-lv2/Makefile.list
5

Duplicate.

yuri marked an inline comment as done.

.

This revision is now accepted and ready to land.Dec 4 2017, 1:27 PM

@tcberner It shows it as "Accepted" and ready to land, but there is no your approval there. :)

Woops, I thought I already accepted this :) -- sorry

Woops, I thought I already accepted this :) -- sorry

No problem! -)

This revision was automatically updated to reflect the committed changes.