Fix the UMA reclaim worker
ClosedPublic
Actions

Authored by markj on Dec 7 2017, 6:53 PM.

Details

Reviewers

kib
jeff
alc

Commits

rS326664: Fix the UMA reclaim worker after r326347.

Summary

atomic_set_* ORs its arguments together, but the intention here was
obviously to clear the flag.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 7 2017, 6:53 PM

Harbormaster completed remote builds in B13408: Diff 36349.Dec 7 2017, 6:53 PM

markj added reviewers: kib, jeff, alc.Dec 7 2017, 6:53 PM

Plain store is enough, _rel does not add any functionality there. Or the load in the while() loop above should become _acq(), but I do not see a need.

This revision is now accepted and ready to land.Dec 7 2017, 7:07 PM

In D13412#280192, @kib wrote:

Plain store is enough, _rel does not add any functionality there. Or the load in the while() loop above should become _acq(), but I do not see a need.

Indeed, but there is no plain atomic_store_int().

In D13412#280195, @markj wrote:

In D13412#280192, @kib wrote:

Plain store is enough, _rel does not add any functionality there. Or the load in the while() loop above should become _acq(), but I do not see a need.

Indeed, but there is no plain atomic_store_int().