Fix the amd64 LINT build
AbandonedPublic
Actions

Authored by markj on Dec 7 2017, 3:40 PM.

Details

Reviewers

ae
tuexen

Summary

sctp_calculate_cksum() is defined only when SCTP_WITH_NO_CSUM is not
defined. If it is, just leave the checksum initialized to 0.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13403
Build 13634: arc lint + arc unit

Event Timeline

markj created this revision.Dec 7 2017, 3:40 PM

Herald added a subscriber: ae. · View Herald TranscriptDec 7 2017, 3:40 PM

Harbormaster completed remote builds in B13403: Diff 36341.Dec 7 2017, 3:40 PM

markj added reviewers: ae, tuexen.Dec 7 2017, 3:41 PM

That doesn't make sense, since SCTP_WITH_NO_CSUM was introduced ages ago just to test how the performance is with checksum offloading. Not computing the checksum in ipfw doesn't make sense...
I suggest that I will just retire SCTP_WITH_NO_CSUM in the source tree. Would that be acceptable?

In D13409#280118, @tuexen wrote:

That doesn't make sense, since SCTP_WITH_NO_CSUM was introduced ages ago just to test how the performance is with checksum offloading. Not computing the checksum in ipfw doesn't make sense...
I suggest that I will just retire SCTP_WITH_NO_CSUM in the source tree. Would that be acceptable?

Sure, my only aim here is to fix the build. :)

Great. Will fix that later today. I'm right now not able to commit things... Thanks for the notice.

markj abandoned this revision.Dec 7 2017, 5:07 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_fw2.c

3 lines

Diff 36341

View Options

Fix the amd64 LINT buildAbandonedPublicActions