Page MenuHomeFreeBSD

Fix the amd64 LINT build
AbandonedPublic

Authored by markj on Dec 7 2017, 3:40 PM.

Details

Reviewers
ae
tuexen
Summary

sctp_calculate_cksum() is defined only when SCTP_WITH_NO_CSUM is not
defined. If it is, just leave the checksum initialized to 0.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13403
Build 13634: arc lint + arc unit

Event Timeline

markj created this revision.Dec 7 2017, 3:40 PM
tuexen added a comment.EditedDec 7 2017, 4:36 PM

That doesn't make sense, since SCTP_WITH_NO_CSUM was introduced ages ago just to test how the performance is with checksum offloading. Not computing the checksum in ipfw doesn't make sense...
I suggest that I will just retire SCTP_WITH_NO_CSUM in the source tree. Would that be acceptable?

markj added a comment.Dec 7 2017, 4:37 PM

That doesn't make sense, since SCTP_WITH_NO_CSUM was introduced ages ago just to test how the performance is with checksum offloading. Not computing the checksum in ipfw doesn't make sense...
I suggest that I will just retire SCTP_WITH_NO_CSUM in the source tree. Would that be acceptable?

Sure, my only aim here is to fix the build. :)

tuexen added a comment.Dec 7 2017, 4:46 PM

Great. Will fix that later today. I'm right now not able to commit things... Thanks for the notice.

markj abandoned this revision.Dec 7 2017, 5:07 PM