Full featured webcam suite
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 13286 Build 13522: arc lint + arc unit
Event Timeline
| multimedia/webcamoid/Makefile | ||
|---|---|---|
| 17 | ^ depends twice on the same port | |
| multimedia/webcamoid/pkg-plist | ||
|---|---|---|
| 87 | this should'n these two files be installed to QT_QMLDIR? (which would be lib/qt5/qml). | |
| multimedia/webcamoid/pkg-plist | ||
|---|---|---|
| 87 | That's the upstream bug. I also noticed it, but I didn't think it was reasonable to patch it. | |
Comment Actions
The patch should be pretty simple to replace the fallback by $$[QT_INSTALL_QML] for INSTALLQMLDIR in commons.pri:
-isEmpty(INSTALLQMLDIR): INSTALLQMLDIR = $${LIBDIR}/qt/qml
+isEmpty(INSTALLQMLDIR): INSTALLQMLDIR = $$[QT_INSTALL_QML]Comment Actions
I would add the url to the issue at the top of the two patches -- that way, one directly sees that they have been upstreamed.
Also you could simply add your git-commit as a patch (i..e. one patch for the two current ones). If you call it something like "patch-git_XXXXXX" it is also clearer that
- this patch can probably be dropped in a future update
- as it will likely be part of the next release
| multimedia/webcamoid/Makefile | ||
|---|---|---|
| 28 | ^ you can drop the comment, I think :) | |