New port: multimedia/webcamoid: Full featured webcam suite

[yuri]

Summary

Full featured webcam suite

[tcberner]

multimedia/webcamoid/Makefile

17 ↗

(On Diff #36125)

^ depends twice on the same port

[yuri]

.

[yuri]

Removed qmake_build, it's a duplicate.

[tcberner]

multimedia/webcamoid/pkg-plist

86 ↗

(On Diff #36133)

this should'n these two files be installed to QT_QMLDIR? (which would be lib/qt5/qml).

[yuri]

multimedia/webcamoid/pkg-plist

86 ↗

(On Diff #36133)

That's the upstream bug. I also noticed it, but I didn't think it was reasonable to patch it.

https://github.com/webcamoid/webcamoid/issues/102

[tcberner]

The patch should be pretty simple to replace the fallback by $$[QT_INSTALL_QML] for INSTALLQMLDIR in commons.pri:

-isEmpty(INSTALLQMLDIR): INSTALLQMLDIR = $${LIBDIR}/qt/qml
+isEmpty(INSTALLQMLDIR): INSTALLQMLDIR = $$[QT_INSTALL_QML]

[yuri]

In D13348#278568, @tcberner wrote:

The patch should be pretty simple to replace the fallback by $$[QT_INSTALL_QML] for INSTALLQMLDIR in commons.pri:

-isEmpty(INSTALLQMLDIR): INSTALLQMLDIR = $${LIBDIR}/qt/qml
+isEmpty(INSTALLQMLDIR): INSTALLQMLDIR = $$[QT_INSTALL_QML]

https://github.com/webcamoid/webcamoid/pull/103

[yuri]

.

[tcberner]

I would add the url to the issue at the top of the two patches -- that way, one directly sees that they have been upstreamed.
Also you could simply add your git-commit as a patch (i..e. one patch for the two current ones). If you call it something like "patch-git_XXXXXX" it is also clearer that

• this patch can probably be dropped in a future update
• as it will likely be part of the next release

[yuri]

In D13348#278583, @yuri wrote:

In D13348#278568, @tcberner wrote:

The patch should be pretty simple to replace the fallback by $$[QT_INSTALL_QML] for INSTALLQMLDIR in commons.pri:

-isEmpty(INSTALLQMLDIR): INSTALLQMLDIR = $${LIBDIR}/qt/qml
+isEmpty(INSTALLQMLDIR): INSTALLQMLDIR = $$[QT_INSTALL_QML]

https://github.com/webcamoid/webcamoid/pull/103

The upstream rejected the patch. They said that this is an intended behavior.

[yuri]

Fixed Qml location in a different way.

[tcberner]

multimedia/webcamoid/Makefile

27 ↗

(On Diff #36147)

^ you can drop the comment, I think :)