Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 13212 Build 13451: arc lint + arc unit
Event Timeline
| cad/sumo/Makefile | ||
|---|---|---|
| 44 | DOCS_SHEBANG_FILES doesn't work. So I will have to put SHEBANG_FILES= docs/tutorial/*/*.py into the option helpers section. Do you still want me to do this? | |
devel/phpbt/Makefile has a conditional USES=shebangfix but SHEBANG_FILES is still used. But shouldn't all such USES arguments be made conditional too?
| cad/sumo/Makefile | ||
|---|---|---|
| 44 | Please see the * (Any variable) bit of the list in 5.13.3. Options Helpers to learn how to deal with variables only needed by options. | |
| cad/sumo/Makefile | ||
|---|---|---|
| 44 | Thanks! | |
| cad/sumo/distinfo | ||
|---|---|---|
| 2 | misses the sumo-doc distfile | |
| cad/sumo/distinfo | ||
|---|---|---|
| 2 | DOCS_DISTFILES is broken. It overwrites DISTFILES instead of adding to it. | |
| cad/sumo/distinfo | ||
|---|---|---|
| 2 | Well, what I told you to do would have worked, but you changed the DISTFILES to DISTNAME, and of course, that broke it. | |
| cad/sumo/Makefile | ||
|---|---|---|
| 7 | I am not sure referencing the PR is a good idea, as it is not a bug, it is documented that way, and it cannot work any other way. | |
| cad/sumo/Makefile | ||
|---|---|---|
| 7 | Removed. | |
Unfortunately not. You need to fix the plist for the debug builds :) -- the binaries get a "D" suffix :)
===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: bin/TraCITestClientD Error: Orphaned: bin/activitygenD [...] ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: bin/TraCITestClient Error: Missing: bin/activitygen [...] ===> Error: Plist issues found. *** Error code 1
I removed the DEBUG option.
It doesn't need to be installed when debugged - it's just a set of executables. Anybody can still enable debug locally.
| cad/sumo/Makefile | ||
|---|---|---|
| 45 | ^ why is this comment still here? | |