New port: cad/sumo: Traffic simulation suite for road vehicles, public transportation, etc

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193884

[mat]

cad/sumo/Makefile

8

The -doc- distfile should probably be in a DOCS_DISTFILES variable.

44–45

This is probably wrong. To install files in STAGEDIR, you must use the INSTALL_* or COPYTREE_* macros so that the rights are correct.

[yuri]

DOCS_DISTFILES.

[mat]

cad/sumo/Makefile

8

This is an option helper, it happens way too early.

42

This should probably be find -d so that recursively empty directories are detected.

43

This should probably be done with USES=shebangfix.

[yuri]

Moved DOCS_DISTFILES to option helpers section.

[yuri]

cad/sumo/Makefile

43

DOCS_SHEBANG_FILES doesn't work. So I will have to put SHEBANG_FILES= docs/tutorial/*/*.py into the option helpers section.

Do you still want me to do this?

[yuri]

devel/phpbt/Makefile has a conditional USES=shebangfix but SHEBANG_FILES is still used. But shouldn't all such USES arguments be made conditional too?

[mat]

cad/sumo/Makefile

43

Please see the * (Any variable) bit of the list in 5.13.3. Options Helpers to learn how to deal with variables only needed by options.

[yuri]

DOCS_VARS

[yuri]

cad/sumo/Makefile

43

Thanks!

[tcberner]

cad/sumo/distinfo

2

misses the sumo-doc distfile

[yuri]

cad/sumo/distinfo

2

DOCS_DISTFILES is broken. It overwrites DISTFILES instead of adding to it.

[mat]

cad/sumo/distinfo

2

Well, what I told you to do would have worked, but you changed the DISTFILES to DISTNAME, and of course, that broke it.

[yuri]

Fixed distfiles.

[yuri]

.

[mat]

cad/sumo/Makefile

8

I am not sure referencing the PR is a good idea, as it is not a bug, it is documented that way, and it cannot work any other way.

[yuri]

Removed bug# comment.

[yuri]

cad/sumo/Makefile

8

Removed.

[yuri]

@tcberner Tobias, does it look like everything is ok?

[tcberner]

Unfortunately not. You need to fix the plist for the debug builds :) -- the binaries get a "D" suffix :)

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/TraCITestClientD
Error: Orphaned: bin/activitygenD
[...]
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: bin/TraCITestClient
Error: Missing: bin/activitygen
[...]
===> Error: Plist issues found.
*** Error code 1

[tcberner]

I suggest using some PLIST_SUB %%DEBUG_SUFFIX%% or soemthing :)

[yuri]

I removed the DEBUG option.
It doesn't need to be installed when debugged - it's just a set of executables. Anybody can still enable debug locally.

[tcberner]

cad/sumo/Makefile

45

^ why is this comment still here?

[yuri]

.