Details
- Reviewers
lifanov - Group Reviewers
Ports Committers - Commits
- rP455300: fix databases/arangodb32 on FreeBSD 10.x
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Also, please remove all the patches from the diff, they do not change.
| databases/arangodb32/Makefile | ||
|---|---|---|
| 41 | Why move this line, it was perfectly fine where it was before. | |
| databases/arangodb32/Makefile | ||
|---|---|---|
| 41 | Because of the inclusion of pre and port makefiles, which help define GYPTGT which is then swapped at compile time. | |
| databases/arangodb32/Makefile | ||
|---|---|---|
| 41 | I am only talking about the CMAKE_ARGS line, there is no reason to move it down here. | |
| databases/arangodb32/Makefile | ||
|---|---|---|
| 41 | It is not moved, that is an append operation that would otherwise fail if kept in the original place, because at that stage GYPTGT is not defined yet. | |
| databases/arangodb32/Makefile | ||
|---|---|---|
| 41 | It would most certainly not fail. make(1) evaluates values when they are used, not when they are defined. Test it. If you put the CMAKE_ARGS line where it was before, it will still work. | |
| databases/arangodb32/Makefile | ||
|---|---|---|
| 41 | Alright, thanks, didn't realize that. | |
| databases/arangodb32/Makefile | ||
|---|---|---|
| 7 | If you are fixing the build, which means that it was not building before, bumping PORTREVISION is not needed. | |