Page MenuHomeFreeBSD
Differential D13204

net-im/ricochet: Unbroke the build. ${OPENSSLDIR}/include coflicted with the STL headers logic; Fixed order
ClosedPublic
Actions

Authored by yuri on Nov 23 2017, 4:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 8, 8:27 AM
Unknown Object (File)
Fri, Aug 28, 4:46 AM
Unknown Object (File)
Fri, Aug 28, 4:27 AM
Unknown Object (File)
Fri, Aug 28, 4:24 AM
Unknown Object (File)
Tue, Aug 18, 8:35 PM
Unknown Object (File)
Tue, Aug 18, 8:12 PM
Unknown Object (File)
Tue, Aug 18, 4:07 PM
Unknown Object (File)
Mon, Aug 17, 7:41 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP455079: net-im/ricochet: Unbroke the build. ${OPENSSLDIR}/include coflicted with the…
Summary

It's strange that it didn't break when it was previously committed a few days ago, but now it was breaking.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13120
Build 13367: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 23 2017, 4:40 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 23 2017, 4:40 AM
Harbormaster completed remote builds in B12961: Diff 35628.Nov 23 2017, 4:40 AM
yuri retitled this revision from net-im/ricochet: Unbroke the build. $${OPENSSLDIR}/include coflicted with the STL headers logic. to net-im/ricochet: Unbroke the build. ${OPENSSLDIR}/include coflicted with the STL headers logic..Nov 23 2017, 5:16 AM
yuri added a comment.Nov 23 2017, 6:34 AM

Upstreamed: https://github.com/ricochet-im/ricochet/pull/563

yuri edited the summary of this revision. (Show Details)Nov 23 2017, 6:28 PM
yuri added a comment.Nov 24 2017, 8:14 PM

This is a simple upstreamed patch unbreaking the build: https://github.com/ricochet-im/ricochet/pull/563

yuri updated this revision to Diff 35878.Nov 27 2017, 5:53 PM

.

Harbormaster completed remote builds in B13120: Diff 35878.Nov 27 2017, 5:53 PM
yuri retitled this revision from net-im/ricochet: Unbroke the build. ${OPENSSLDIR}/include coflicted with the STL headers logic. to net-im/ricochet: Unbroke the build. ${OPENSSLDIR}/include coflicted with the STL headers logic; Fixed order.Nov 27 2017, 5:54 PM
tcberner accepted this revision.Nov 28 2017, 7:19 PM
tcberner added inline comments.
net-im/ricochet/Makefile
26

^ probably does not need to be += -- you can look at that at a later time :)

This revision is now accepted and ready to land.Nov 28 2017, 7:19 PM
yuri marked an inline comment as done.Nov 28 2017, 9:33 PM
yuri added inline comments.
net-im/ricochet/Makefile
26

Ok, thanks! I will add a note to myself. :)

Closed by commit rP455079: net-im/ricochet: Unbroke the build. ${OPENSSLDIR}/include coflicted with the… (authored by yuri). · Explain WhyNov 28 2017, 9:37 PM
This revision was automatically updated to reflect the committed changes.
yuri marked an inline comment as done.

Revision Contents
Changeset List

PathSize
net-im/
ricochet/
16 lines
files/
16 lines

Diff 35878

View Options

net-im/ricochet/Makefile

Loading...
View Options

net-im/ricochet/files/patch-ricochet.pro

Loading...