Paths

Table of Contentst

Differential D13238

New port: audio/fluidplug-lv2: SoundFonts as LV2 plugins via FluidSynth
ClosedPublic
Actions

Authored by yuri on Nov 25 2017, 6:28 AM.

Tags

None

Referenced Files

	F151139240: D13238.id35873.diff
	Mon, Apr 6, 8:47 AM

	F151129591: D13238.id35778.diff
	Mon, Apr 6, 7:02 AM

	F151116725: D13238.id35755.diff
	Mon, Apr 6, 4:48 AM

	F151111772: D13238.id35762.diff
	Mon, Apr 6, 3:54 AM

	F151110912: D13238.id36378.diff
	Mon, Apr 6, 3:44 AM

	F151106059: D13238.id36378.diff
	Mon, Apr 6, 2:48 AM

	F151051307: D13238.id35873.diff
	Sun, Apr 5, 4:15 PM

	Unknown Object (File)
	Sun, Apr 5, 7:19 AM

Subscribers

Details

Reviewers

tcberner
adamw
mat

Commits

rP455774: New port: audio/fluidplug-lv2: SoundFonts as LV2 plugins via FluidSynth

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221486

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13043
Build 13296: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 25 2017, 6:28 AM

Herald added a subscriber: mat. · View Herald TranscriptNov 25 2017, 6:28 AM

Harbormaster completed remote builds in B13043: Diff 35755.Nov 25 2017, 6:28 AM

.

Harbormaster completed remote builds in B13044: Diff 35756.Nov 25 2017, 6:38 AM

tcberner added inline comments.Nov 25 2017, 9:35 AM

audio/fluidplug-lv2/Makefile
16	^ new port: sort :)

yuri marked an inline comment as done.Nov 25 2017, 9:41 AM

.

Harbormaster completed remote builds in B13049: Diff 35762.Nov 25 2017, 9:41 AM

tcberner added inline comments.Nov 25 2017, 1:43 PM

audio/fluidplug-lv2/Makefile.list
27	^ close one, let's hope they don't add two more :D

Replaced the repetitious statements with for clauses.

Harbormaster completed remote builds in B13059: Diff 35778.Nov 25 2017, 8:57 PM

yuri marked an inline comment as done.Nov 25 2017, 8:57 PM

mat requested changes to this revision.Nov 27 2017, 1:30 PM

mat added inline comments.

audio/fluidplug-lv2/Makefile
24	Default, remove.
audio/fluidplug-lv2/Makefile.list
4–6	First, this is better written as: MASTER_SITES+= http://download.linuxaudio.org/musical-instrument-libraries/sf2/AVL-Drumkits-1.1-SF2-splitted/:b,c,d,e,f,g Second, this is better written as simply `:b` (or some other group with a more descriptive name) and use `:b` for all the distfiles that need this particular directory.

This revision now requires changes to proceed.Nov 27 2017, 1:30 PM

.

Harbormaster completed remote builds in B13110: Diff 35866.Nov 27 2017, 5:32 PM

yuri marked an inline comment as done.Nov 27 2017, 5:32 PM

mat added inline comments.Nov 27 2017, 5:39 PM

audio/fluidplug-lv2/Makefile.list
5	Duplicate.

.

Harbormaster completed remote builds in B13116: Diff 35873.Nov 27 2017, 5:46 PM

Fixed.

@mat Anything else here?

mat accepted this revision.Dec 4 2017, 1:27 PM

This revision is now accepted and ready to land.Dec 4 2017, 1:27 PM

@tcberner Tobias, can this be committed?

@tcberner It shows it as "Accepted" and ready to land, but there is no your approval there. :)

Woops, I thought I already accepted this :) -- sorry

tcberner accepted this revision.Dec 8 2017, 6:15 AM

In D13238#280367, @tcberner wrote:

Woops, I thought I already accepted this :) -- sorry

No problem! -)

Closed by commit rP455774: New port: audio/fluidplug-lv2: SoundFonts as LV2 plugins via FluidSynth (authored by yuri). · Explain WhyDec 8 2017, 7:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

audio/

1 line

40 lines

52 lines

53 lines

4 lines

376 lines

Diff 35755

audio/Makefile

Loading...

audio/fluidplug-lv2/

Loading...

audio/fluidplug-lv2/Makefile

Loading...

audio/fluidplug-lv2/Makefile.list

Loading...

audio/fluidplug-lv2/distinfo

Loading...

audio/fluidplug-lv2/pkg-descr

Loading...

audio/fluidplug-lv2/pkg-plist

Loading...