Page MenuHomeFreeBSD
Differential D13237

New port: science/ALPSCore: Generic algorithms and utilities for condensed matter physics
ClosedPublic
Actions

Authored by yuri on Nov 25 2017, 2:23 AM.
Tags
None
Referenced Files
F106132404: D13237.id35846.diff
Wed, Dec 25, 10:43 PM
Unknown Object (File)
Nov 25 2024, 2:05 PM
Unknown Object (File)
Nov 24 2024, 12:50 PM
Unknown Object (File)
Nov 18 2024, 1:40 AM
Unknown Object (File)
Nov 16 2024, 5:24 PM
Unknown Object (File)
Nov 14 2024, 9:28 PM
Unknown Object (File)
Nov 11 2024, 3:57 AM
Unknown Object (File)
Nov 5 2024, 3:41 AM
View All 73 Files
Subscribers
mat
Contributor Reviewers (ports)

Details

Reviewers
tcberner
adamw
Commits
rP455424: New port: science/ALPSCore: Generic algorithms and utilities for condensed…
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223850

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13042
Build 13295: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 25 2017, 2:23 AM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptNov 25 2017, 2:23 AM
Harbormaster completed remote builds in B13039: Diff 35750.Nov 25 2017, 2:23 AM
yuri updated this revision to Diff 35753.Nov 25 2017, 6:21 AM

.

Harbormaster completed remote builds in B13041: Diff 35753.Nov 25 2017, 6:21 AM
yuri added reviewers: tcberner, adamw.Nov 25 2017, 6:21 AM
yuri updated this revision to Diff 35754.Nov 25 2017, 6:24 AM

.

Harbormaster completed remote builds in B13042: Diff 35754.Nov 25 2017, 6:24 AM
tcberner added inline comments.Nov 25 2017, 9:24 AM
science/alpscore/Makefile
38

i think you could use

OPENMPI2_VARS= cc=${LOCALBASE}/mpi/openmpi2/bin/mpicc \
               cxx=${LOCALBASE}/mpi/openmpi2/bin/mpicxx

instead of including bsd.port.options.mk and option matching.

yuri marked an inline comment as done.Nov 25 2017, 9:31 AM
yuri updated this revision to Diff 35761.Nov 25 2017, 9:31 AM

.

tcberner added inline comments.Nov 25 2017, 9:51 AM
science/alpscore/Makefile
4

Usual complaint:
Port: science/alpscore -> Pkg: ALPSCore-1.0.0

Our filesystems support uper case names, why not use them and get rid of the two seconds it takes to
cd /usr/ports/science/ALP<tab> *huh?* *ah* cd /usr/ports/science/alpscore

Tradition is a very poor counter argument to annoyance, in my opinion :D

yuri marked an inline comment as done.Nov 25 2017, 9:56 AM
yuri added inline comments.
science/alpscore/Makefile
4

I full-heartedly agree with you! :)

yuri marked 2 inline comments as done.Nov 25 2017, 9:56 AM
tcberner added inline comments.Nov 27 2017, 6:46 AM
science/alpscore/Makefile
4

So, are you going to rename the directory to 'science/ALPScore' then? :)

yuri marked an inline comment as done.Nov 27 2017, 6:52 AM
yuri added inline comments.
science/alpscore/Makefile
4

Aren't people strongly against it?
I recently asked this question in the ML: https://lists.freebsd.org/pipermail/freebsd-ports/2017-November/thread.html#111028

There were only negative responses. :(

Do you think I should still rename it?

yuri updated this revision to Diff 35846.Nov 27 2017, 7:55 AM
yuri marked an inline comment as done.

Renamed into science/ALPSCore.

Harbormaster completed remote builds in B13104: Diff 35846.Nov 27 2017, 7:55 AM
yuri retitled this revision from New port: science/alpscore: Generic algorithms and utilities for condensed matter physics to New port: science/ALPSCore: Generic algorithms and utilities for condensed matter physics.Nov 27 2017, 7:55 AM
yuri added a comment.Nov 30 2017, 5:09 PM
This comment was removed by yuri.
yuri added a comment.Dec 3 2017, 6:33 PM

@tcberner Let's commit this one?

tcberner accepted this revision.Dec 3 2017, 7:22 PM
This revision is now accepted and ready to land.Dec 3 2017, 7:22 PM
Closed by commit rP455424: New port: science/ALPSCore: Generic algorithms and utilities for condensed… (authored by yuri). · Explain WhyDec 3 2017, 7:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
science/
1 line
48 lines
3 lines
9 lines
131 lines

Diff 35754

View Options

science/Makefile

Loading...
View Options

science/alpscore/

Loading...
View Options

science/alpscore/Makefile

Loading...
View Options

science/alpscore/distinfo

Loading...
View Options

science/alpscore/pkg-descr

Loading...
View Options

science/alpscore/pkg-plist

Loading...