intuitive way
ClosedPublic
Actions

Authored by yuri on Nov 8 2017, 5:04 AM.

Details

Reviewers

tcberner
adamw

Commits

rP454848: New port: multimedia/py-pretty_midi: Utility functions for handling MIDI data…

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220752

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13021
Build 13275: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 8 2017, 5:04 AM

Herald added a subscriber: mat. · View Herald TranscriptNov 8 2017, 5:04 AM

tcberner added inline comments.Nov 8 2017, 6:48 AM

multimedia/py-pretty-midi/Makefile
15 ↗	(On Diff #34925)	py-mido is missing

tcberner added a parent revision: D12995: New port: multimedia/py-mido: MIDI Objects for Python.Nov 8 2017, 6:49 AM

Sorry, I didn't first create the dependency.

In D12998#269928, @yuri wrote:

Sorry, I didn't first create the dependency.

no worries :)

mat added inline comments.Nov 8 2017, 12:52 PM

multimedia/py-pretty-midi/Makefile
3 ↗	(On Diff #34925)	PORTNAME and directory name are not the same, one `_` and one `-`.

yuri marked 2 inline comments as done.Nov 12 2017, 4:54 AM

yuri added inline comments.Nov 12 2017, 8:49 AM

multimedia/py-pretty-midi/Makefile
3 ↗	(On Diff #34925)	GitHub directory has `-`, but pypi.python.org directory has `_`. I think we should go with the original version, which is GitHub.

yuri marked an inline comment as done.Nov 12 2017, 9:29 PM

tcberner added inline comments.Nov 17 2017, 10:48 PM

multimedia/py-pretty-midi/Makefile
3 ↗	(On Diff #34925)	Then you should also call the port 'pretty-midi' multimedia/py-pretty-midi -> py27-pretty_midi-0.2.8 just is not nice, if you ask me.

yuri marked an inline comment as done.Nov 23 2017, 6:42 AM

yuri added inline comments.

multimedia/py-pretty-midi/Makefile
3 ↗	(On Diff #34925)	So, the package is now called pretty_midi.

mat added inline comments.Nov 24 2017, 6:13 PM

multimedia/py-pretty-midi/Makefile
3 ↗	(On Diff #34925)	So the port directory should be with a `_`.

Renamed the port dir.

yuri marked 2 inline comments as done.Nov 24 2017, 7:52 PM

yuri retitled this revision from New port: multimedia/py-pretty-midi: Utility functions for handling MIDI data in a nice/intuitive way to New port: multimedia/py-pretty_midi: Utility functions for handling MIDI data in a nice/intuitive way.

Macro stlgtm:
matching names.. makes my little heart jump