Page MenuHomeFreeBSD

New port: multimedia/py-pretty_midi: Utility functions for handling MIDI data in a nice/intuitive way
ClosedPublic

Authored by yuri on Nov 8 2017, 5:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 4 2024, 2:28 PM
Unknown Object (File)
Mar 4 2024, 2:28 PM
Unknown Object (File)
Mar 4 2024, 2:28 PM
Unknown Object (File)
Mar 4 2024, 2:28 PM
Unknown Object (File)
Mar 3 2024, 4:35 PM
Unknown Object (File)
Feb 20 2024, 12:36 AM
Unknown Object (File)
Jan 30 2024, 5:17 PM
Unknown Object (File)
Jan 21 2024, 1:47 AM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

multimedia/py-pretty-midi/Makefile
15 ↗(On Diff #34925)

py-mido is missing

Sorry, I didn't first create the dependency.

In D12998#269928, @yuri wrote:

Sorry, I didn't first create the dependency.

no worries :)

multimedia/py-pretty-midi/Makefile
3 ↗(On Diff #34925)

PORTNAME and directory name are not the same, one _ and one -.

yuri marked 2 inline comments as done.Nov 12 2017, 4:54 AM
multimedia/py-pretty-midi/Makefile
3 ↗(On Diff #34925)

GitHub directory has -, but pypi.python.org directory has _. I think we should go with the original version, which is GitHub.

yuri marked an inline comment as done.Nov 12 2017, 9:29 PM
multimedia/py-pretty-midi/Makefile
3 ↗(On Diff #34925)

Then you should also call the port 'pretty-midi'

multimedia/py-pretty-midi -> py27-pretty_midi-0.2.8

just is not nice, if you ask me.

yuri marked an inline comment as done.Nov 23 2017, 6:42 AM
yuri added inline comments.
multimedia/py-pretty-midi/Makefile
3 ↗(On Diff #34925)

So, the package is now called pretty_midi.

multimedia/py-pretty-midi/Makefile
3 ↗(On Diff #34925)

So the port directory should be with a _.

yuri marked an inline comment as done.

Renamed the port dir.

yuri marked 2 inline comments as done.Nov 24 2017, 7:52 PM
yuri retitled this revision from New port: multimedia/py-pretty-midi: Utility functions for handling MIDI data in a nice/intuitive way to New port: multimedia/py-pretty_midi: Utility functions for handling MIDI data in a nice/intuitive way.

Macro stlgtm:
matching names.. makes my little heart jump

matching names.. makes my little heart jump

Tobias, mat asked for directory to be named with underscore. What should be changed?

That's exactly what I wanted too :)

As long as @mat has nothing more to add this is good to go from my side.

This revision is now accepted and ready to land.Nov 24 2017, 8:29 PM
This revision was automatically updated to reflect the committed changes.

You have to read my accepting comments, not just commit :)

You have to read my accepting comments, not just commit :)

Sorry!