Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 12988 Build 13242: arc lint + arc unit
Event Timeline
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
16 | ^maybe it would be a bit more compact to use the pkgname to depend on it instead of these long paths :) |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
6–7 | MASTER_SITES= SF/${THEME:tW:tl:S/ /-/g} Never use MASTER_SITE_SUBDIR. |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
16 |
I grant you it's nicer to depend on a file, but these paths just look too long and subject o change :D |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
16 | This didn't occur to me fast enough. -) |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
34 | ^out of curiousity. Have you checked whether they are really not requiring any bash features? |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
34 | -) Of course I did. They are all very simple and plain scripts. |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
7 | ^ is this a joke? ^^ |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
7 | No, it reuses the THEME variable. |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
7 | well, the punchline is on line 3, isn't it? |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
34 | very good :) |
There're actually fewer lines without THEME, and it's easier to read. So it's better in this case IMO.
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
30 | ^ I think you could come up with something nicer here Which might look a bit cleaner. |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
30 | I simplified it. -) |
x11-themes/xfce-evolution/Makefile | ||
---|---|---|
7 | I am definitely laughing! Is the subdir likely to change? If not, it's probably safe to hardcode it. | |
35 | Just FYI, if you wanted to, you could also use shebangfix here, which is very precise about how it modifies files. USES=shebangfix SHEBANG_REGEX= 00.[0-4]0 bash_CMD=/bin/sh |