New port: x11-themes/xfce-evolution: Complete Xfce Evolution Gtk2, Gtk3, Qt4, Qt5, wxWidgets, Xfce themes

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223825

[tcberner]

x11-themes/xfce-evolution/Makefile

17

^maybe it would be a bit more compact to use the pkgname to depend on it instead of these long paths :)

[mat]

x11-themes/xfce-evolution/Makefile

7–8

MASTER_SITES=        SF/${THEME:tW:tl:S/ /-/g}

Never use MASTER_SITE_SUBDIR.

[yuri]

.

[yuri]

x11-themes/xfce-evolution/Makefile

7–8

Updated.
Should MASTER_SITE_SUBDIR be renamed into _MASTER_SITE_SUBDIR then in Mk/?

17

How to do this?

For example, RUN_DEPENDS=gtk-murrine-engine:x11-themes/gtk-murrine-engine doesn't work.

[tcberner]

x11-themes/xfce-evolution/Makefile

17

|Porters Handbook

A minimal version of a dependency can be specified in any *_DEPENDS except LIB_DEPENDS using this syntax:

p5-Spiffy>=0.26:devel/p5-Spiffy

The first field contains a dependent package name, which must match the entry in the package database, a comparison sign, and a package version. The > dependency is satisfied if p5-Spiffy-0.26 or newer is installed on the machine.

I grant you it's nicer to depend on a file, but these paths just look too long and subject o change :D

[yuri]

Depend on the package.

[yuri]

x11-themes/xfce-evolution/Makefile

17

This didn't occur to me fast enough. -)

[tcberner]

x11-themes/xfce-evolution/Makefile

33

^out of curiousity. Have you checked whether they are really not requiring any bash features?

[yuri]

x11-themes/xfce-evolution/Makefile

33

-) Of course I did. They are all very simple and plain scripts.

[tcberner]

x11-themes/xfce-evolution/Makefile

6

^ is this a joke? ^^

[yuri]

x11-themes/xfce-evolution/Makefile

6

No, it reuses the THEME variable.
Would you prefer to just type the text instead?

[tcberner]

x11-themes/xfce-evolution/Makefile

6

well, the punchline is on line 3, isn't it?

[tcberner]

x11-themes/xfce-evolution/Makefile

33

very good :)

[yuri]

Removed THEME: it was a bad idea.

[tcberner]

In D13219#275779, @yuri wrote:

Removed THEME: it was a bad idea.

I wouldn't call it a bad idea :) just not ideally used

[yuri]

In D13219#275789, @tcberner wrote:

I wouldn't call it a bad idea :) just not ideally used

There're actually fewer lines without THEME, and it's easier to read. So it's better in this case IMO.

[tcberner]

In D13219#275795, @yuri wrote:

In D13219#275789, @tcberner wrote:

I wouldn't call it a bad idea :) just not ideally used

There're actually fewer lines without THEME, and it's easier to read. So it's better in this case IMO.

Yes, I meant that playing around with variables is not bad per se :)

[tcberner]

x11-themes/xfce-evolution/Makefile

30

^ I think you could come up with something nicer here
a) is it really important to get rid of the whitespaces?
b) you only want to replace the whitepsaces in "Xfce Theme <Foo>", so maybe iterate over the Foo's you want to install and do a ${COPYTREE_SHARE} "Xfce Theme ${FOO}" ${STAGEDIR}${PREFIX}/share/themes/Xfce-Theme-${FOO}"
or some valid variation thereof.

Which might look a bit cleaner.

[yuri]

Simplified scripts.

[yuri]

x11-themes/xfce-evolution/Makefile

30

I simplified it. -)

[adamw]

x11-themes/xfce-evolution/Makefile

6

I am definitely laughing!

Is the subdir likely to change? If not, it's probably safe to hardcode it.

35

Just FYI, if you wanted to, you could also use shebangfix here, which is very precise about how it modifies files.

USES=shebangfix
SHEBANG_REGEX= 00.[0-4]0
bash_CMD=/bin/sh

[yuri]

Update.

[tcberner]

Looks good to me now :) -- if @adamw is ok with the SHEBANG changes, go for it .

[adamw]

In D13219#275948, @tcberner wrote:

Looks good to me now :) -- if @adamw is ok with the SHEBANG changes, go for it .

LGTM too!