Page MenuHomeFreeBSD
Differential D13026

loader.efi: efipart does not recognize partitionless disks
ClosedPublic
Actions

Authored by tsoome on Nov 10 2017, 12:39 PM.
Tags
None
Referenced Files
F105833874: D13026.diff
Sat, Dec 21, 10:37 AM
Unknown Object (File)
Fri, Dec 13, 10:41 AM
Unknown Object (File)
Wed, Dec 11, 2:58 PM
Unknown Object (File)
Thu, Dec 5, 8:52 AM
Unknown Object (File)
Wed, Nov 27, 6:09 AM
Unknown Object (File)
Wed, Nov 27, 6:09 AM
Unknown Object (File)
Wed, Nov 27, 6:09 AM
Unknown Object (File)
Wed, Nov 27, 6:09 AM
View All 75 Files
Subscribers
None

Details

Reviewers
imp
allanjude
Commits
rS326089: loader.efi: efipart does not recognize partitionless disks
Summary

Rework the block device handle check to allow more robust device
classification.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12827
Build 13091: arc lint + arc unit

Event Timeline

tsoome created this revision.Nov 10 2017, 12:39 PM
Harbormaster completed remote builds in B12617: Diff 35030.Nov 10 2017, 12:39 PM
tsoome updated this revision to Diff 35042.Nov 10 2017, 5:05 PM

efipart_hdd() was quite broken.

Harbormaster completed remote builds in B12621: Diff 35042.Nov 10 2017, 5:05 PM
tsoome updated this revision to Diff 35276.Nov 15 2017, 1:12 PM

Update to revision 325851.

Harbormaster completed remote builds in B12758: Diff 35276.Nov 15 2017, 1:12 PM
imp accepted this revision.Nov 15 2017, 2:55 PM

This looks OK, but the code could use some high level comments outlining the algorithms used since they are becoming harder to discern from the just reading the code.

This revision is now accepted and ready to land.Nov 15 2017, 2:55 PM
tsoome added a comment.Nov 15 2017, 3:13 PM
In D13026#272423, @imp wrote:

This looks OK, but the code could use some high level comments outlining the algorithms used since they are becoming harder to discern from the just reading the code.

Yes, those are waiting in queue - I have some suggestions from illumos review and need to move those over here too.

tsoome updated this revision to Diff 35404.Nov 18 2017, 10:57 AM

Add more comments and reorder some checks

This revision now requires review to proceed.Nov 18 2017, 10:57 AM
Closed by commit rS326089: loader.efi: efipart does not recognize partitionless disks (authored by tsoome). · Explain WhyNov 22 2017, 8:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stand/
efi/
libefi/
111 lines

Diff 35404

View Options

stand/efi/libefi/efipart.c

Loading...