Page MenuHomeFreeBSD

loader.efi: efipart does not recognize partitionless disks
ClosedPublic

Authored by tsoome on Nov 10 2017, 12:39 PM.
Tags
None
Referenced Files
F105833874: D13026.diff
Sat, Dec 21, 10:37 AM
Unknown Object (File)
Fri, Dec 13, 10:41 AM
Unknown Object (File)
Wed, Dec 11, 2:58 PM
Unknown Object (File)
Thu, Dec 5, 8:52 AM
Unknown Object (File)
Wed, Nov 27, 6:09 AM
Unknown Object (File)
Wed, Nov 27, 6:09 AM
Unknown Object (File)
Wed, Nov 27, 6:09 AM
Unknown Object (File)
Wed, Nov 27, 6:09 AM
Subscribers
None

Details

Summary

Rework the block device handle check to allow more robust device
classification.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12617
Build 12888: arc lint + arc unit

Event Timeline

efipart_hdd() was quite broken.

Update to revision 325851.

This looks OK, but the code could use some high level comments outlining the algorithms used since they are becoming harder to discern from the just reading the code.

This revision is now accepted and ready to land.Nov 15 2017, 2:55 PM
In D13026#272423, @imp wrote:

This looks OK, but the code could use some high level comments outlining the algorithms used since they are becoming harder to discern from the just reading the code.

Yes, those are waiting in queue - I have some suggestions from illumos review and need to move those over here too.

Add more comments and reorder some checks

This revision now requires review to proceed.Nov 18 2017, 10:57 AM
This revision was automatically updated to reflect the committed changes.