Page MenuHomeFreeBSD
Differential D13075

Add port of latte-dock
ClosedPublic
Actions

Authored by adridg on Nov 13 2017, 11:23 PM.
Tags
None
Referenced Files
F82939243: D13075.id35319.diff
Sat, May 4, 6:20 AM
Unknown Object (File)
Fri, May 3, 9:03 PM
Unknown Object (File)
Fri, May 3, 9:02 PM
Unknown Object (File)
Fri, May 3, 9:02 PM
Unknown Object (File)
Fri, May 3, 9:02 PM
Unknown Object (File)
Fri, May 3, 9:02 PM
Unknown Object (File)
Fri, May 3, 9:02 PM
Unknown Object (File)
Wed, May 1, 12:19 PM
View All 76 Files
Subscribers
mat

Details

Reviewers
tcberner
rakuco
Commits
rP454392: Add latte-dock, an alternative launcher / taskbar from the KDE community.
Summary

Latte-dock is an alternative launcher / task manager for Qt- and Plasma-
based desktops.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adridg created this revision.Nov 13 2017, 11:23 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 13 2017, 11:23 PM
Harbormaster completed remote builds in B12727: Diff 35211.Nov 13 2017, 11:23 PM
tcberner added inline comments.Nov 14 2017, 5:59 AM
deskutils/latte-dock/Makefile
17 ↗(On Diff #35211)

^ line breaks

18 ↗(On Diff #35211)

I would prefer

USE_QT5= core dbus gui network qml quick widgets x11extras xml \
                 buildtools_build qmake_build
tcberner added inline comments.Nov 14 2017, 6:01 AM
deskutils/latte-dock/Makefile
12 ↗(On Diff #35211)

I had this for the git-port of it:
LICENSE_FILE= ${WRKSRC}/COPYING

is the LICENSE file not present in the official release?

adridg updated this revision to Diff 35228.Nov 14 2017, 11:42 AM

Line breaks, polish LICENSE data.

Harbormaster completed remote builds in B12739: Diff 35228.Nov 14 2017, 11:42 AM
adridg marked 3 inline comments as done.Nov 14 2017, 11:56 AM
tcberner added inline comments.Nov 14 2017, 5:25 PM
deskutils/latte-dock/Makefile
17 ↗(On Diff #35228)

^ according to portlint, you should invest in gettext stocks

deskutils/latte-dock/pkg-plist
2 ↗(On Diff #35228)

%%QT_QMLDIR%%/org/kde/latte/liblattedockplugin.so

adridg updated this revision to Diff 35319.Nov 16 2017, 10:30 AM

Massage pkg-plist

Harbormaster completed remote builds in B12782: Diff 35319.Nov 16 2017, 10:30 AM
adridg marked an inline comment as done.Nov 16 2017, 10:39 AM
adridg added inline comments.
deskutils/latte-dock/Makefile
17 ↗(On Diff #35228)

This is one of those weird cases where my portlint doesn't tell me that. And there was also sayonara, remember, where I added gettext-runtime (because of portlint) and then removed it later because it turned out ot be a false positive and something else was pulling it in already.

tcberner added inline comments.Nov 16 2017, 6:43 PM
deskutils/latte-dock/Makefile
17 ↗(On Diff #35228)
-A          Turn on all additional checks.

-C          Pedantic committer flag.  This is equivalent to -abcmt.
adridg updated this revision to Diff 35370.Nov 17 2017, 11:34 AM

Pet the human portlint. Update WWW to point to KDE.

Harbormaster completed remote builds in B12809: Diff 35370.Nov 17 2017, 11:34 AM
adridg marked 3 inline comments as done.Nov 17 2017, 11:35 AM
tcberner accepted this revision.Nov 17 2017, 7:16 PM

Apart from that little += issue it's good to go.

deskutils/latte-dock/Makefile
15 ↗(On Diff #35370)

^= not +=

This revision is now accepted and ready to land.Nov 17 2017, 7:16 PM
Closed by commit rP454392: Add latte-dock, an alternative launcher / taskbar from the KDE community. (authored by adridg). · Explain WhyNov 17 2017, 11:11 PM
This revision was automatically updated to reflect the committed changes.
mat added inline comments.Nov 24 2017, 5:37 PM
head/deskutils/latte-dock/Makefile
6–7
MASTER_SITES=        KDE/stable/latte-dock

Don't use MASTER_SITE_SUBDIR.

Revision Contents
Changeset List

PathSize
head/
deskutils/
1 line
latte-dock/
27 lines
3 lines
6 lines
214 lines

Diff 35392

View Options

head/deskutils/Makefile

Loading...
View Options

head/deskutils/latte-dock/Makefile

Loading...
View Options

head/deskutils/latte-dock/distinfo

Loading...
View Options

head/deskutils/latte-dock/pkg-descr

Loading...
View Options

head/deskutils/latte-dock/pkg-plist

Loading...