Page MenuHomeFreeBSD

New port: math/ambit: C++ library for tensor product calculations
ClosedPublic

Authored by yuri on Nov 13 2017, 2:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 3, 10:35 AM
Unknown Object (File)
Sun, Mar 3, 10:35 AM
Unknown Object (File)
Sun, Mar 3, 10:35 AM
Unknown Object (File)
Sun, Mar 3, 10:35 AM
Unknown Object (File)
Sun, Mar 3, 10:35 AM
Unknown Object (File)
Sun, Mar 3, 10:35 AM
Unknown Object (File)
Sun, Mar 3, 10:35 AM
Unknown Object (File)
Sun, Mar 3, 10:23 AM
Subscribers

Details

Summary

Needed to support the psi4 quantum chemistry package

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12747
Build 13015: arc lint + arc unit

Event Timeline

Good morning :)

It does not like 10.3:

-- Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES) (found version "1.0")
-- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES) (found version "1.0")
CMake Error at cmake/custom_cxxstandard.cmake:52 (message):
  CLANG version must be at least 3.6!
Call Stack (most recent call first):
  CMakeLists.txt:74 (include)


-- Configuring incomplete, errors occurred!
See also "/wrkdirs/usr/ports/math/ambit/work/.build/CMakeFiles/CMakeOutput.log".
See also "/wrkdirs/usr/ports/math/ambit/work/.build/CMakeFiles/CMakeError.log".
*** Error code 1

Fixed the clang version for 10.

math/ambit/Makefile
30

^ I'm not sure whether hard-depending on one version of clang is a great idea as they get dropped eventually.

math/ambit/Makefile
26

^ I think using <bsd.port.pre.mk> (and <bsd.port.post.mk> at the bottom) would be more proper than using <bsd.options.mk>, as you are really not using any option specific stuff here.

https://www.freebsd.org/doc/en/books/porters-handbook/dads-after-port-mk.html

yuri marked 2 inline comments as done.Nov 16 2017, 9:40 PM
yuri added inline comments.
math/ambit/Makefile
30

I am not sure how this can be solved. Eventually, every specific version will be dropped.

The right way would have been having USES=compiler:clang>3.6.

This already came up before, without a clear solution.

yuri marked an inline comment as done.

Updated .include to pre/post
Added OPEN_MP=OFF because it can't be found

yuri marked an inline comment as done.Nov 18 2017, 6:24 PM
tcberner added inline comments.
math/ambit/Makefile
33

^ you need += here. After including bsd.pre.mk BUILD_DEPENDS already contains cmake:devel/cmake from the USES=cmake line. Which you override here :)

So this port will fail to configure on FreeBSD < 11, as cmake is not installed.

root@103amd32-yuri:/usr/ports/math/ambit # make -VBUILD_DEPENDS
clang38:lang/clang38 /usr/local/bin/ccache:devel/ccache
This revision now requires changes to proceed.Nov 18 2017, 9:42 PM

Replaced = with += as requested.

yuri marked an inline comment as done.Nov 18 2017, 9:45 PM
yuri added inline comments.
math/ambit/Makefile
33

Thanks for catching this!

This revision is now accepted and ready to land.Nov 18 2017, 9:52 PM
This revision was automatically updated to reflect the committed changes.
yuri marked an inline comment as done.