Page MenuHomeFreeBSD
Differential D12986

New port: audio/abgate-lv2: Noise gate LV2 plugin
ClosedPublic
Actions

Authored by yuri on Nov 7 2017, 11:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 19 2024, 4:49 PM
Unknown Object (File)
Nov 19 2024, 4:49 PM
Unknown Object (File)
Nov 19 2024, 4:48 PM
Unknown Object (File)
Nov 19 2024, 4:48 PM
Unknown Object (File)
Nov 19 2024, 4:48 PM
Unknown Object (File)
Nov 19 2024, 3:05 AM
Unknown Object (File)
Nov 12 2024, 1:24 AM
Unknown Object (File)
Nov 11 2024, 4:51 AM
View All 95 Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP453986: New port: audio/abgate-lv2: Noise gate LV2 plugin
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221683

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12583
Build 12858: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 7 2017, 11:24 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 7 2017, 11:24 PM
mat added inline comments.Nov 8 2017, 12:28 PM
audio/abgate-lv2/Makefile
21

Change PORTNAME to aBGate and remove the GH_PROJECT line.

yuri updated this revision to Diff 34953.Nov 8 2017, 5:13 PM

Changed PORTNAME to mixed case.

Harbormaster completed remote builds in B12583: Diff 34953.Nov 8 2017, 5:13 PM
yuri marked an inline comment as done.Nov 8 2017, 5:15 PM
tcberner added a comment.Nov 10 2017, 7:55 PM

Maybe also rename the directory to abGate-lv2 -- I personally like it if it is matching, but I think there are others that are very opposed to capital letters :)

yuri added a comment.Nov 10 2017, 10:00 PM
In D12986#270784, @tcberner wrote:

Maybe also rename the directory to abGate-lv2 -- I personally like it if it is matching, but I think there are others that are very opposed to capital letters :)

I also would like directory to be abGate, but I named one port's directory qTox once, and I remember getting unhappy e-mails about this.
I will ask for extra-opinions on ports@.

yuri added a comment.Nov 11 2017, 8:47 AM
In D12986#270784, @tcberner wrote:

Maybe also rename the directory to abGate-lv2 -- I personally like it if it is matching, but I think there are others that are very opposed to capital letters :)

Kurt Jaeger opined that he is for lowercase, let's just keep it lowercase?

tcberner added inline comments.Nov 11 2017, 1:25 PM
audio/abgate-lv2/Makefile
31

you should not use ${LOCALBASE}/llib/qt4/bin/qmake -- qmake should work. [QT_SELECT=qt4 is in both CONFIGURE_ENV and MAKE_ENV].

If you need the path to qmake, you should ask bsd.qt.mk for it, and use ${QMAKE}, or ${QT_BINDIR}/qmake.
Which seems more robust than to just assume it' in ${LOCALBASE}/lib/qt4/bin/

yuri updated this revision to Diff 35110.Nov 11 2017, 4:34 PM

qmake

Harbormaster completed remote builds in B12663: Diff 35110.Nov 11 2017, 4:34 PM
yuri marked an inline comment as done.Nov 11 2017, 4:34 PM
tcberner accepted this revision.Nov 11 2017, 5:48 PM
This revision is now accepted and ready to land.Nov 11 2017, 5:48 PM
Closed by commit rP453986: New port: audio/abgate-lv2: Noise gate LV2 plugin (authored by yuri). · Explain WhyNov 11 2017, 6:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
audio/
1 line
41 lines
3 lines
3 lines
9 lines

Diff 34953

View Options

audio/Makefile

Loading...
View Options

audio/abgate-lv2/

Loading...
View Options

audio/abgate-lv2/Makefile

Loading...
View Options

audio/abgate-lv2/distinfo

Loading...
View Options

audio/abgate-lv2/pkg-descr

Loading...
View Options

audio/abgate-lv2/pkg-plist

Loading...