Page MenuHomeFreeBSD

New port: audio/abgate-lv2: Noise gate LV2 plugin
ClosedPublic

Authored by yuri on Nov 7 2017, 11:24 PM.
Tags
None
Referenced Files
F132437357: D12986.id35114.diff
Thu, Oct 16, 10:50 PM
F132437354: D12986.id35110.diff
Thu, Oct 16, 10:50 PM
F132437348: D12986.id34953.diff
Thu, Oct 16, 10:50 PM
F132437346: D12986.id.diff
Thu, Oct 16, 10:50 PM
F132437340: D12986.id34906.diff
Thu, Oct 16, 10:50 PM
F132436468: D12986.diff
Thu, Oct 16, 10:38 PM
Unknown Object (File)
Fri, Sep 26, 11:00 AM
Unknown Object (File)
Thu, Sep 25, 2:51 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

audio/abgate-lv2/Makefile
20 ↗(On Diff #34906)

Change PORTNAME to aBGate and remove the GH_PROJECT line.

Changed PORTNAME to mixed case.

yuri marked an inline comment as done.Nov 8 2017, 5:15 PM

Maybe also rename the directory to abGate-lv2 -- I personally like it if it is matching, but I think there are others that are very opposed to capital letters :)

Maybe also rename the directory to abGate-lv2 -- I personally like it if it is matching, but I think there are others that are very opposed to capital letters :)

I also would like directory to be abGate, but I named one port's directory qTox once, and I remember getting unhappy e-mails about this.
I will ask for extra-opinions on ports@.

Maybe also rename the directory to abGate-lv2 -- I personally like it if it is matching, but I think there are others that are very opposed to capital letters :)

Kurt Jaeger opined that he is for lowercase, let's just keep it lowercase?

audio/abgate-lv2/Makefile
31 ↗(On Diff #34953)

you should not use ${LOCALBASE}/llib/qt4/bin/qmake -- qmake should work. [QT_SELECT=qt4 is in both CONFIGURE_ENV and MAKE_ENV].

If you need the path to qmake, you should ask bsd.qt.mk for it, and use ${QMAKE}, or ${QT_BINDIR}/qmake.
Which seems more robust than to just assume it' in ${LOCALBASE}/lib/qt4/bin/

yuri marked an inline comment as done.Nov 11 2017, 4:34 PM
This revision is now accepted and ready to land.Nov 11 2017, 5:48 PM
This revision was automatically updated to reflect the committed changes.