The OpenGLFunctions are required by qutebrowser.
Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 12547 Build 12822: arc lint + arc unit
Event Timeline
Another cosmetic change would be to put CONFIGURE_ARGS= and PYQT_DIST= after the USES and USE_x block to conform to the ordering specified in Chapter 14. of the Porter's Handbook.
x11/py-qt5-opengl/Makefile | ||
---|---|---|
33 | why not just ${STRIP_CMD$ ${STAGEDIR}${PREFIX}/lib/${PYTHON_VERSION}/site-packages/PyQt5/*.so |
I think that can be done later, as all the PyQt ports probably can use that cleanup -- but I'm not mad, if you already include it here :)
x11/py-qt5-opengl/Makefile | ||
---|---|---|
37 | Why not use PYTHON_SITELIBDIR? |
I'm not clear why we are not just specifying USE_PYQT=sip_build, then allowing consumers to specify the complete required list for USE_PYQT.
I mean why doesn't this port simply use USE_PYQT=sip_build and then consumers of py-qt5 modules, like www/qutebrowser, specify the full list of modules it requires?
I'd say because you can install py-qt5 standalone without any applications using it (say for in house stuff) -- which should then also be able to run, and therefore pull in the required "real" Qt5 foo.
That makes sense, but why would a user install py-qt5-opengl to get many (but not all) py-qt5/qt5 modules. For users that want a more complete installation of py-qt5, maybe we could create a meta-port that pulls in the modules.
There already exists such a meta port :) -- Maybe I don't quite understand what the problem is here :)
x11/py-qt5-opengl/Makefile | ||
---|---|---|
10–17 | Out of order. See Chapter 14. Order of Variables in Port Makefiles. | |
24 | missing a tab after =. |
x11/py-qt5-opengl/Makefile | ||
---|---|---|
10–17 | See the comments on this diff where I suggested this, but was asked to wait. |
x11/py-qt5-opengl/Makefile | ||
---|---|---|
10–17 | Well, "we'll do it later" usually means it'll never be done, so unless someone has a todo list with this item on it with an actual deadline that is not three years in the future, it is probably better to do this now. |
x11/py-qt5-opengl/Makefile | ||
---|---|---|
10–17 | I noticed some other "stuff to cleanup" for the PyQt ports, so it's on a Todo list here :) |
That being said, and thought about, @mat is right. There is no good reason to wait for me to find time to do them all in one go, so please add the cleanups already :)
- Order variable blocks according to Chapter 14. of the Porter's Handbook
- Add a comment about LICENSE to prevent portlint warnings and for clarity for others viewing the Makefile
x11/py-qt5-opengl/Makefile | ||
---|---|---|
16 | which reminds me to commit this... give me some minutes :D |