Page MenuHomeFreeBSD
Differential D12954

New port: audio/luppp: Live looping music creation tool
ClosedPublic
Actions

Authored by yuri on Nov 4 2017, 8:01 PM.
Tags
None
Referenced Files
F106134435: D12954.id34796.diff
Wed, Dec 25, 11:28 PM
F106133310: D12954.id34793.diff
Wed, Dec 25, 11:03 PM
F106104647: D12954.diff
Wed, Dec 25, 11:40 AM
Unknown Object (File)
Nov 25 2024, 7:04 AM
Unknown Object (File)
Nov 19 2024, 4:17 PM
Unknown Object (File)
Nov 19 2024, 4:17 PM
Unknown Object (File)
Nov 19 2024, 4:17 PM
Unknown Object (File)
Nov 19 2024, 4:17 PM
View All 85 Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP453707: New port: audio/luppp: Live looping music creation tool
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222440

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12464
Build 12739: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 4 2017, 8:01 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 4 2017, 8:01 PM
Harbormaster completed remote builds in B12464: Diff 34786.Nov 4 2017, 8:01 PM
tcberner added inline comments.Nov 4 2017, 8:24 PM
audio/luppp/Makefile
18

^you could sort these

20

^cmake:outsource

25

USE_GNOME before USE_XORg

audio/luppp/files/patch-src_CMakeLists.txt
16

why is this move needed?

yuri marked 3 inline comments as done.Nov 4 2017, 8:29 PM
yuri added inline comments.
audio/luppp/files/patch-src_CMakeLists.txt
16

This is the upstreamed patch that fixes the build. It was the include order problem.

yuri updated this revision to Diff 34793.Nov 4 2017, 8:30 PM
yuri marked an inline comment as done.

Requested changes.

Harbormaster completed remote builds in B12471: Diff 34793.Nov 4 2017, 8:30 PM
tcberner added inline comments.Nov 4 2017, 8:35 PM
audio/luppp/files/patch-src_CMakeLists.txt
16

if it's upstreamed, include the url a top of the patch so that people looking at it don't have the same reaction as I jsut did :) -- , or even better rename the patch to
patch-git_<rev>
and use the upstream commit as patch :)

yuri marked an inline comment as done.Nov 4 2017, 8:45 PM
yuri updated this revision to Diff 34796.Nov 4 2017, 8:45 PM

Removed the patch, updated the revision tag.

Harbormaster completed remote builds in B12473: Diff 34796.Nov 4 2017, 8:45 PM
tcberner added a comment.Nov 4 2017, 8:48 PM
In D12954#268983, @yuri wrote:

Removed the patch, updated the revision tag.

or that :D

tcberner accepted this revision.Nov 7 2017, 10:17 PM

Looks good to me.

This revision is now accepted and ready to land.Nov 7 2017, 10:17 PM
yuri closed this revision.Nov 7 2017, 10:22 PM
yuri marked an inline comment as done.

Revision Contents
Changeset List

PathSize
audio/
1 line
39 lines
3 lines
21 lines
6 lines

Diff 34786

View Options

audio/Makefile

Loading...
View Options

audio/luppp/

Loading...
View Options

audio/luppp/Makefile

Loading...
View Options

audio/luppp/distinfo

Loading...
View Options

audio/luppp/files/

Loading...
View Options

audio/luppp/files/patch-src_CMakeLists.txt

Loading...
View Options

audio/luppp/pkg-descr

Loading...