Page MenuHomeFreeBSD

New port: audio/luppp: Live looping music creation tool
ClosedPublic

Authored by yuri on Nov 4 2017, 8:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 8:50 PM
Unknown Object (File)
Fri, Jun 21, 1:26 PM
Unknown Object (File)
Tue, Jun 11, 10:33 PM
Unknown Object (File)
Tue, Jun 11, 10:29 PM
Unknown Object (File)
Tue, Jun 11, 10:29 PM
Unknown Object (File)
Tue, Jun 11, 9:45 PM
Unknown Object (File)
Tue, Jun 11, 9:26 PM
Unknown Object (File)
Apr 19 2024, 1:16 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12473
Build 12748: arc lint + arc unit

Event Timeline

audio/luppp/Makefile
19

^you could sort these

21

^cmake:outsource

26

USE_GNOME before USE_XORg

audio/luppp/files/patch-src_CMakeLists.txt
16 ↗(On Diff #34786)

why is this move needed?

yuri marked 3 inline comments as done.Nov 4 2017, 8:29 PM
yuri added inline comments.
audio/luppp/files/patch-src_CMakeLists.txt
16 ↗(On Diff #34786)

This is the upstreamed patch that fixes the build. It was the include order problem.

yuri marked an inline comment as done.

Requested changes.

audio/luppp/files/patch-src_CMakeLists.txt
16 ↗(On Diff #34786)

if it's upstreamed, include the url a top of the patch so that people looking at it don't have the same reaction as I jsut did :) -- , or even better rename the patch to
patch-git_<rev>
and use the upstream commit as patch :)

yuri marked an inline comment as done.Nov 4 2017, 8:45 PM

Removed the patch, updated the revision tag.

In D12954#268983, @yuri wrote:

Removed the patch, updated the revision tag.

or that :D

This revision is now accepted and ready to land.Nov 7 2017, 10:17 PM
yuri marked an inline comment as done.