Page MenuHomeFreeBSD

loader ptblread() is broken with >512B sectors
ClosedPublic

Authored by tsoome on Oct 31 2017, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 2, 7:54 PM
Unknown Object (File)
Wed, May 22, 12:54 PM
Unknown Object (File)
May 16 2024, 2:52 AM
Unknown Object (File)
May 15 2024, 6:25 PM
Unknown Object (File)
May 1 2024, 2:54 PM
Unknown Object (File)
Mar 17 2024, 6:30 AM
Unknown Object (File)
Dec 22 2023, 11:48 PM
Unknown Object (File)
Dec 15 2023, 11:31 AM
Subscribers
None

Details

Summary

The loader strategy() function is assuming 512B blocks, so we need to adjust
ptblread() for other sector sizes.

Test Plan

use lsdev -v from loader OK prompt to confirm the partition table.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I will test this on my macbookpro NVMe where FreeBSD currently cannot read the partition table.

This looks good to me.... It will certainly be a NOP for 512 byte sectors.

This revision is now accepted and ready to land.Oct 31 2017, 3:10 PM
This revision now requires review to proceed.Oct 31 2017, 8:05 PM
This revision was automatically updated to reflect the committed changes.