Page MenuHomeFreeBSD
Differential D12847

loader ptblread() is broken with >512B sectors
ClosedPublic
Actions

Authored by tsoome on Oct 31 2017, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 27, 6:43 PM
Unknown Object (File)
Mon, Apr 27, 11:47 AM
Unknown Object (File)
Sat, Apr 25, 10:11 PM
Unknown Object (File)
Apr 10 2026, 8:32 AM
Unknown Object (File)
Mar 22 2026, 5:02 AM
Unknown Object (File)
Mar 20 2026, 5:18 AM
Unknown Object (File)
Mar 18 2026, 6:19 AM
Unknown Object (File)
Mar 18 2026, 6:19 AM
View All Files
Subscribers
None

Details

Reviewers
allanjude
imp
Commits
rS325248: loader ptblread() is broken with >512B sectors
Summary

The loader strategy() function is assuming 512B blocks, so we need to adjust
ptblread() for other sector sizes.

Test Plan

use lsdev -v from loader OK prompt to confirm the partition table.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12349
Build 12634: arc lint + arc unit

Event Timeline

tsoome created this revision.Oct 31 2017, 11:48 AM
allanjude added a comment.Oct 31 2017, 11:51 AM

I will test this on my macbookpro NVMe where FreeBSD currently cannot read the partition table.

imp accepted this revision.Oct 31 2017, 3:10 PM

This looks good to me.... It will certainly be a NOP for 512 byte sectors.

This revision is now accepted and ready to land.Oct 31 2017, 3:10 PM
tsoome updated this revision to Diff 34566.Oct 31 2017, 8:05 PM

Reword the comment.

This revision now requires review to proceed.Oct 31 2017, 8:05 PM
Closed by commit rS325248: loader ptblread() is broken with >512B sectors (authored by tsoome). · Explain WhyOct 31 2017, 8:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
boot/
common/
6 lines

Diff 34566

View Options

sys/boot/common/disk.c

Loading...