Page MenuHomeFreeBSD
Differential D12849

efipart_strategy is using wrong offset with >512B sectors
ClosedPublic
Actions

Authored by tsoome on Oct 31 2017, 11:53 AM.
Tags
None
Referenced Files
F131734798: D12849.id34502.diff
Fri, Oct 10, 6:15 PM
F131718110: D12849.diff
Fri, Oct 10, 2:52 PM
Unknown Object (File)
Tue, Oct 7, 2:15 AM
Unknown Object (File)
Fri, Oct 3, 4:17 AM
Unknown Object (File)
Thu, Oct 2, 6:55 AM
Unknown Object (File)
Wed, Oct 1, 2:20 PM
Unknown Object (File)
Tue, Sep 30, 10:31 AM
Unknown Object (File)
Mon, Sep 22, 12:43 PM
View All 99 Files
Subscribers
None

Details

Reviewers
allanjude
imp
eric_metricspace.net
Commits
rS325286: efipart_strategy is using wrong offset with >512B sectors
Summary

The strategy() calls are assuming 512B sectors, so we need to adjust the
offset accordingly.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12350
Build 12635: arc lint + arc unit

Event Timeline

tsoome created this revision.Oct 31 2017, 11:53 AM
Harbormaster completed remote builds in B12326: Diff 34502.Oct 31 2017, 11:53 AM
imp accepted this revision.Oct 31 2017, 3:11 PM
imp added inline comments.
sys/boot/efi/libefi/efipart.c
880–884

why shift and not offset?

This revision is now accepted and ready to land.Oct 31 2017, 3:11 PM
tsoome updated this revision to Diff 34567.Oct 31 2017, 8:22 PM

offset is better name.

This revision now requires review to proceed.Oct 31 2017, 8:22 PM
imp accepted this revision.Oct 31 2017, 8:29 PM
This revision is now accepted and ready to land.Oct 31 2017, 8:29 PM
Closed by commit rS325286: efipart_strategy is using wrong offset with >512B sectors (authored by tsoome). · Explain WhyNov 1 2017, 6:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
boot/
efi/
libefi/
6 lines

Diff 34567

View Options

sys/boot/efi/libefi/efipart.c

Loading...