loader ptblread() is broken with >512B sectors
ClosedPublic
Actions

Authored by tsoome on Oct 31 2017, 11:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 17, 8:30 AM

	Unknown Object (File)
	Mon, Nov 17, 5:54 AM

	Unknown Object (File)
	Mon, Nov 17, 3:14 AM

	Unknown Object (File)
	Sun, Nov 16, 8:14 PM

	Unknown Object (File)
	Sun, Nov 16, 2:21 PM

	Unknown Object (File)
	Sun, Nov 16, 11:53 AM

	Unknown Object (File)
	Sun, Nov 16, 9:53 AM

	Unknown Object (File)
	Mon, Nov 10, 2:07 AM

View All Files

Subscribers

None

Details

Reviewers

allanjude
imp

Commits

rS325248: loader ptblread() is broken with >512B sectors

Summary

The loader strategy() function is assuming 512B blocks, so we need to adjust
ptblread() for other sector sizes.

Test Plan

use lsdev -v from loader OK prompt to confirm the partition table.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12349
Build 12634: arc lint + arc unit

Event Timeline

tsoome created this revision.Oct 31 2017, 11:48 AM

I will test this on my macbookpro NVMe where FreeBSD currently cannot read the partition table.

This looks good to me.... It will certainly be a NOP for 512 byte sectors.

This revision is now accepted and ready to land.Oct 31 2017, 3:10 PM

Reword the comment.

This revision now requires review to proceed.Oct 31 2017, 8:05 PM

Closed by commit rS325248: loader ptblread() is broken with >512B sectors (authored by tsoome). · Explain WhyOct 31 2017, 8:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

boot/

common/

disk.c

6 lines

Diff 34566

View Options

loader ptblread() is broken with >512B sectorsClosedPublicActions