Improve robustness of owner/mode settings.
ClosedPublic
Actions

Authored by delphij on Oct 19 2017, 8:14 AM.

Tags

None

Referenced Files

	F100611254: D12726.diff
	Thu, Oct 17, 9:36 AM

	Unknown Object (File)
	Wed, Oct 16, 4:33 AM

	Unknown Object (File)
	Mon, Oct 14, 8:43 PM

	Unknown Object (File)
	Sat, Oct 12, 7:49 AM

	Unknown Object (File)
	Fri, Oct 11, 12:21 AM

	Unknown Object (File)
	Thu, Oct 10, 7:32 AM

	Unknown Object (File)
	Tue, Oct 8, 2:06 AM

	Unknown Object (File)
	Mon, Oct 7, 12:47 AM

View All 84 Files

Subscribers

None

Details

Reviewers

matthew
mat

Group Reviewers

ports secteam

Commits

rP453157: Improve robustness of owner/mode settings.

Summary

Run fcgiwrap under target credential and only change ownership if the credential do not match the current socket_owner/group setting.
Use umask instead of chmod.
Use nobody/nogroup for default credentials instead of root.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij created this revision.Oct 19 2017, 8:14 AM

Harbormaster completed remote builds in B12120: Diff 34139.Oct 19 2017, 8:14 AM

Looks ok to me, might want to explain a bit the umask thing, took me a few minutes to see what you were doing.

This revision is now accepted and ready to land.Oct 26 2017, 2:49 PM

Closed by commit rP453157: Improve robustness of owner/mode settings. (authored by delphij). · Explain WhyOct 30 2017, 5:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

www/

fcgiwrap/

Makefile

2 lines

files/

fcgiwrap.in

23 lines

Diff 34446

View Options

head/www/fcgiwrap/Makefile