Page MenuHomeFreeBSD

Always send STANDBY IMMEDIATE when shutting down
ClosedPublic

Authored by imp on Oct 26 2017, 6:49 PM.
Tags
None
Referenced Files
F175474556: D12799.id34367.diff
Sun, Oct 11, 3:18 AM
F175455507: D12799.id34378.diff
Sat, Oct 10, 11:59 PM
Unknown Object (File)
Wed, Oct 7, 3:26 AM
Unknown Object (File)
Mon, Oct 5, 2:40 AM
Unknown Object (File)
Mon, Oct 5, 2:33 AM
Unknown Object (File)
Mon, Oct 5, 2:30 AM
Unknown Object (File)
Sun, Sep 20, 6:30 AM
Unknown Object (File)
Sat, Sep 19, 2:13 AM
Subscribers
None

Details

Summary

To save SMART data and for a drive to understand that it's been nicely
shutdown, we need to send a STANDBY IMMEDIATE. Modify adaspindown to
use a local CCB on the stack. When we're panicing, used
xpt_polled_action rather than cam_periph_runccb so that we can SEND
IMMEDIATE after we've shutdown the scheduler.

Sponsored by: Netflix

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12246
Build 12537: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Oct 26 2017, 6:52 PM
sys/cam/ata/ata_da.c
3519

This should be adaerror()

imp marked an inline comment as done.Oct 26 2017, 7:49 PM

Will fix the cosmetics before push.

This revision was automatically updated to reflect the committed changes.