Page MenuHomeFreeBSD
Differential D12726

Improve robustness of owner/mode settings.
ClosedPublic
Actions

Authored by delphij on Oct 19 2017, 8:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 8, 10:29 PM
Unknown Object (File)
Tue, Aug 5, 5:00 AM
Unknown Object (File)
Sun, Aug 3, 3:02 PM
Unknown Object (File)
Sat, Jul 26, 7:12 AM
Unknown Object (File)
Tue, Jul 22, 4:53 PM
Unknown Object (File)
Tue, Jul 22, 4:51 PM
Unknown Object (File)
Tue, Jul 22, 4:43 PM
Unknown Object (File)
Tue, Jul 22, 3:40 PM
View All Files
Subscribers
None

Details

Reviewers
matthew
mat
Group Reviewers
ports secteam
Commits
rP453157: Improve robustness of owner/mode settings.
Summary
  • Run fcgiwrap under target credential and only change ownership if the credential do not match the current socket_owner/group setting.
  • Use umask instead of chmod.
  • Use nobody/nogroup for default credentials instead of root.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12120
Build 12421: arc lint + arc unit

Event Timeline

delphij created this revision.Oct 19 2017, 8:14 AM
Harbormaster completed remote builds in B12120: Diff 34139.Oct 19 2017, 8:14 AM
mat accepted this revision.Oct 26 2017, 2:49 PM

Looks ok to me, might want to explain a bit the umask thing, took me a few minutes to see what you were doing.

This revision is now accepted and ready to land.Oct 26 2017, 2:49 PM
Closed by commit rP453157: Improve robustness of owner/mode settings. (authored by delphij). · Explain WhyOct 30 2017, 5:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
www/
fcgiwrap/
2 lines
files/
23 lines

Diff 34139

View Options

www/fcgiwrap/Makefile

Loading...
View Options

www/fcgiwrap/files/fcgiwrap.in

Loading...