Page MenuHomeFreeBSD
Differential D12663

Move swapout code into vm_swapout.c.
ClosedPublic
Actions

Authored by kib on Oct 13 2017, 7:05 PM.
Tags
None
Referenced Files
F105790001: D12663.id34171.diff
Fri, Dec 20, 5:50 PM
F105773121: D12663.diff
Fri, Dec 20, 12:15 PM
Unknown Object (File)
Sun, Dec 8, 11:58 PM
Unknown Object (File)
Mon, Dec 2, 6:33 AM
Unknown Object (File)
Sat, Nov 30, 5:23 PM
Unknown Object (File)
Sat, Nov 23, 11:26 PM
Unknown Object (File)
Nov 7 2024, 7:49 AM
Unknown Object (File)
Nov 6 2024, 4:58 PM
View All 81 Files
Subscribers
imp

Details

Reviewers
alc
markj
Commits
rS324795: Move swapout code into vm/vm_swapout.c.
Summary

There is no NO_SWAPPING #ifdef left in the code.

Test Plan

Compile-tested only ATM. Both !NO_SWAPPING and NO_SWAPPING configs.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 12037

Event Timeline

kib created this revision.Oct 13 2017, 7:05 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 13 2017, 7:05 PM
kib edited the summary of this revision. (Show Details)Oct 13 2017, 7:09 PM
markj accepted this revision.Oct 13 2017, 7:31 PM

Looks ok to me. I like this approach better than, e.g., ffs_softdep.c, where the stubs are kept in the same file.

sys/vm/vm_swapout_dummy.c
71

Extra newline.

This revision is now accepted and ready to land.Oct 13 2017, 7:31 PM
kib marked an inline comment as done.Oct 13 2017, 8:06 PM
kib updated this revision to Diff 33969.Oct 13 2017, 8:13 PM

Remove empty line.
Do not ever return from NO_SWAPPING swapper().

This revision now requires review to proceed.Oct 13 2017, 8:13 PM
alc accepted this revision.Oct 19 2017, 5:14 AM
This revision is now accepted and ready to land.Oct 19 2017, 5:14 AM
Closed by commit rS324795: Move swapout code into vm/vm_swapout.c. (authored by kib). · Explain WhyOct 20 2017, 9:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
conf/
4 lines
sys/
4 lines
vm/
1 line
501 lines
9 lines
395 lines
976 lines
119 lines

Diff 33965

View Options

sys/conf/files

Loading...
View Options

sys/sys/_kstack_cache.h

Loading...
View Options

sys/vm/vm_extern.h

Loading...
View Options

sys/vm/vm_glue.c

Loading...
View Options

sys/vm/vm_pageout.h

Loading...
View Options

sys/vm/vm_pageout.c

Loading...
View Options

sys/vm/vm_swapout.c

Loading...
View Options

sys/vm/vm_swapout_dummy.c

Loading...