Evaluate the real size of the sblk_zone.
ClosedPublic
Actions

Authored by kib on Oct 13 2017, 3:28 PM.

Tags

None

Referenced Files

	F137070328: D12660.id33958.diff
	Fri, Nov 21, 2:15 AM

	F137069823: D12660.id.diff
	Fri, Nov 21, 2:14 AM

	F137069377: D12660.id33961.diff
	Fri, Nov 21, 2:13 AM

	F137069271: D12660.id33957.diff
	Fri, Nov 21, 2:13 AM

	F137067915: D12660.diff
	Fri, Nov 21, 2:09 AM

	Unknown Object (File)
	Sat, Nov 15, 6:49 PM

	Unknown Object (File)
	Sun, Nov 9, 10:07 PM

	Unknown Object (File)
	Thu, Nov 6, 12:24 PM

View All 89 Files

Subscribers

imp

Details

Reviewers

alc
markj

Commits

rS324600: Evaluate the real size of the sblk_zone.

Summary

This allows to not waste some small amount of memory, if available.

Submitted by: ota@j.email.ne.jp
PR: 221356

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Oct 13 2017, 3:28 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 13 2017, 3:28 PM

I think that the change is fine, but it needs a comment. Otherwise, this is going to look awfully strange to someone who isn't familiar with the inner works of UMA.

Makes sense to me.

This revision is now accepted and ready to land.Oct 13 2017, 3:37 PM

Add comment.

This revision now requires review to proceed.Oct 13 2017, 3:50 PM

alc accepted this revision.Oct 13 2017, 4:05 PM

alc added inline comments.

sys/vm/swap_pager.c
546–548	"Often uma_zone_reserve_kva() cannot reserve exactly the requested size. Account for the difference when calculating swap_maxpages.

This revision is now accepted and ready to land.Oct 13 2017, 4:05 PM

markj accepted this revision.Oct 13 2017, 4:20 PM

Closed by commit rS324600: Evaluate the real size of the sblk_zone. (authored by kib). · Explain WhyOct 13 2017, 4:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

vm/

swap_pager.c

8 lines

Diff 33958

View Options

Evaluate the real size of the sblk_zone.ClosedPublicActions