Page MenuHomeFreeBSD
Differential D12502

mountd: Convert exportlist to SLIST
ClosedPublic
Actions

Authored by manu on Sep 26 2017, 8:40 AM.
Tags
None
Referenced Files
F170767042: D12502.id33435.diff
Sun, Sep 6, 12:40 PM
F170660785: D12502.id33435.diff
Sat, Sep 5, 9:12 PM
Unknown Object (File)
Sat, Sep 5, 2:22 PM
Unknown Object (File)
Sat, Sep 5, 1:05 AM
Unknown Object (File)
Thu, Sep 3, 2:19 AM
Unknown Object (File)
Thu, Sep 3, 1:01 AM
Unknown Object (File)
Wed, Sep 2, 1:37 PM
Unknown Object (File)
Tue, Sep 1, 9:43 AM
View All Files
Subscribers
imp

Details

Reviewers
bapt
rmacklem
Commits
rS324955: MFC r324257-r324258
rS324257: mountd: Convert exportlist to SLIST
Summary

Use SLIST from sys/queue.h instead of homebrew linked list for the exportlist.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Sep 26 2017, 8:40 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 26 2017, 8:40 AM
bapt added a comment.Sep 26 2017, 8:55 AM

You are losing the "alphabetical order insertion, but I don't think it is a problem.

manu added a comment.Sep 26 2017, 8:58 AM
In D12502#259239, @bapt wrote:

You are losing the "alphabetical order insertion, but I don't think it is a problem.

Yes, I don't see any reason for keeping it alphabetically sorted so I removed that.

manu updated this revision to Diff 33438.Sep 26 2017, 9:01 AM

Make the SLIST static

bapt accepted this revision.Sep 26 2017, 9:03 AM
This revision is now accepted and ready to land.Sep 26 2017, 9:03 AM
rmacklem accepted this revision.Oct 3 2017, 11:45 PM

I've accepted this. As bapt@ noted, it loses the alphabetical order.
I don't know if that matters. I believe it means that the reply to
"showmount -e" will not be alphabetically ordered. Does any
client care? I don't know.

Closed by commit rS324257: mountd: Convert exportlist to SLIST (authored by manu). · Explain WhyOct 4 2017, 8:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
mountd/
42 lines

Diff 33676

View Options

head/usr.sbin/mountd/mountd.c

Loading...