Page MenuHomeFreeBSD
Differential D12502

mountd: Convert exportlist to SLIST
ClosedPublic
Actions

Authored by manu on Sep 26 2017, 8:40 AM.
Tags
None
Referenced Files
F84259763: D12502.id33676.diff
Tue, May 21, 2:15 PM
F84246433: D12502.id33438.diff
Tue, May 21, 9:41 AM
F84245755: D12502.id33435.diff
Tue, May 21, 9:27 AM
Unknown Object (File)
Thu, May 16, 5:55 AM
Unknown Object (File)
Wed, May 1, 8:43 PM
Unknown Object (File)
Wed, May 1, 6:38 AM
Unknown Object (File)
Sat, Apr 27, 2:18 PM
Unknown Object (File)
Mar 2 2024, 7:23 PM
View All 43 Files
Subscribers
imp

Details

Reviewers
bapt
rmacklem
Commits
rS324955: MFC r324257-r324258
rS324257: mountd: Convert exportlist to SLIST
Summary

Use SLIST from sys/queue.h instead of homebrew linked list for the exportlist.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Sep 26 2017, 8:40 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 26 2017, 8:40 AM
bapt added a comment.Sep 26 2017, 8:55 AM

You are losing the "alphabetical order insertion, but I don't think it is a problem.

manu added a comment.Sep 26 2017, 8:58 AM
In D12502#259239, @bapt wrote:

You are losing the "alphabetical order insertion, but I don't think it is a problem.

Yes, I don't see any reason for keeping it alphabetically sorted so I removed that.

manu updated this revision to Diff 33438.Sep 26 2017, 9:01 AM

Make the SLIST static

bapt accepted this revision.Sep 26 2017, 9:03 AM
This revision is now accepted and ready to land.Sep 26 2017, 9:03 AM
rmacklem accepted this revision.Oct 3 2017, 11:45 PM

I've accepted this. As bapt@ noted, it loses the alphabetical order.
I don't know if that matters. I believe it means that the reply to
"showmount -e" will not be alphabetically ordered. Does any
client care? I don't know.

Closed by commit rS324257: mountd: Convert exportlist to SLIST (authored by manu). · Explain WhyOct 4 2017, 8:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
mountd/
42 lines

Diff 33676

View Options

head/usr.sbin/mountd/mountd.c

Loading...