Fix if_awg tx dma status reg offsets
ClosedPublic
Actions

Authored by guyyur_gmail.com on Sep 28 2017, 6:05 PM.

Details

Reviewers

manu
jmcneill

Commits

rS324117: Fix if_awg tx dma status reg offsets.

Summary

if_awg tx dma status regs start at 0xb0 according to the data sheet.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guyyur_gmail.com created this revision.Sep 28 2017, 6:05 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptSep 28 2017, 6:05 PM

Well spotted, thanks! (how did this ever work?)

This revision is now accepted and ready to land.Sep 30 2017, 10:11 AM

Closed by commit rS324117: Fix if_awg tx dma status reg offsets. (authored by jmcneill). · Explain WhySep 30 2017, 10:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

allwinner/

if_awgreg.h

6 lines

Diff 33585

View Options

head/sys/arm/allwinner/if_awgreg.h

	Show All 17 Lines
	.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)			.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
	.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT			.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
	.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY			.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
	.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF			.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
	.\" SUCH DAMAGE.			.\" SUCH DAMAGE.
	.\"			.\"
	.\" $FreeBSD$			.\" $FreeBSD$
	.\"			.\"
	.Dd February 21, 2016			.Dd June 22, 2018
	.Dt CONFIG 5			.Dt CONFIG 5
	.Os			.Os
	.Sh NAME			.Sh NAME
	.Nm config			.Nm config
	.Nd kernel configuration file format			.Nd kernel configuration file format
	.Sh DESCRIPTION			.Sh DESCRIPTION
	A kernel configuration file specifies the configuration of a			A kernel configuration file specifies the configuration of a
	.Fx			.Fx
	▲ Show 20 Lines • Show All 84 Lines • ▼ Show 20 Lines
	.Xr loader 8 .			.Xr loader 8 .
	This directive makes the kernel ignore the boot environment and use			This directive makes the kernel ignore the boot environment and use
	the compiled-in environment instead, unless the boot environment contains			the compiled-in environment instead, unless the boot environment contains
	.Va static_env.disabled=1 .			.Va static_env.disabled=1 .
	.Pp			.Pp
	This directive is useful for setting kernel tunables in			This directive is useful for setting kernel tunables in
	embedded environments that do not start from			embedded environments that do not start from
	.Xr loader 8 .			.Xr loader 8 .
				.\" -------- ENVVAR --------
				.Pp
				.It Ic envvar Ar setting
				Specifies an individual environment setting to be added to the kernel's
				compiled-in environment.
				.Ar setting
				must be of the form
				.Dq Va name=value .
				Optional quotes are supported in both name and value.
				ianUnsubmitted Not Done Inline Actions If we change this documentation a bit, the limitations of the lexer seem almost like a feature... .Ar setting must be of the form .Dq Va Qo name Qc = Qq value . Quotes are required around the value. Quotes are required around the name only if it contains non-alphanumeric characters. ian: If we change this documentation a bit, the limitations of the lexer seem almost like a feature..
				kevansAuthorUnsubmitted Not Done Inline Actions "Oh that? That's neither a wart nor a bug, good sir! That there is a feature!" You're not wrong, though. Let's look at the upsides: It's still pretty clear and functional, albeit obviously different from loader.conf(5) environment and env files If you get it wrong, you get a syntax error instead of incorrect behavior kevans: "Oh that? That's neither a wart nor a bug, good sir! That there is a feature!" You're not…
				ianUnsubmitted Not Done Inline Actions It's not really different though... loader.conf theoretically requires quoted lhs, but single-word things work fine unquoted so people do that. This would be the same (except unquoted numbers don't work). Also, env files would work exactly the same with the new sanitizer, you could put "a.b"="thing" in an env file and get exactly the same result as you would with envvar "a.b"="thing". ian: It's not really different though... loader.conf theoretically requires quoted lhs, but single…
				All environment variables specified with
				.Ic envvar
				will be set after any
				.Ic env
				files are included.
	.\" -------- FILES --------			.\" -------- FILES --------
	.Pp			.Pp
	.It Ic files Ar filename			.It Ic files Ar filename
	Specifies a file containing a list of files specific to that kernel			Specifies a file containing a list of files specific to that kernel
	configuration file (a la			configuration file (a la
	.Pa files. Ns Aq Ar arch ) .			.Pa files. Ns Aq Ar arch ) .
	.\" -------- HINTS --------			.\" -------- HINTS --------
	.Pp			.Pp
	▲ Show 20 Lines • Show All 267 Lines • Show Last 20 Lines

Fix if_awg tx dma status reg offsetsClosedPublicActions