mountd: Convert exportlist to SLIST
ClosedPublic
Actions

Authored by manu on Sep 26 2017, 8:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 7, 10:15 AM

	Unknown Object (File)
	Tue, Jun 24, 10:20 PM

	Unknown Object (File)
	Fri, Jun 20, 2:39 PM

	Unknown Object (File)
	Wed, Jun 18, 8:37 AM

	Unknown Object (File)
	Sun, Jun 15, 7:41 PM

	Unknown Object (File)
	Jun 13 2025, 10:03 AM

	Unknown Object (File)
	Jun 12 2025, 10:00 AM

	Unknown Object (File)
	Jun 11 2025, 10:29 AM

View All 89 Files

Subscribers

imp

Details

Reviewers

bapt
rmacklem

Commits

rS324955: MFC r324257-r324258
rS324257: mountd: Convert exportlist to SLIST

Summary

Use SLIST from sys/queue.h instead of homebrew linked list for the exportlist.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Sep 26 2017, 8:40 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 26 2017, 8:40 AM

You are losing the "alphabetical order insertion, but I don't think it is a problem.

In D12502#259239, @bapt wrote:

You are losing the "alphabetical order insertion, but I don't think it is a problem.

Yes, I don't see any reason for keeping it alphabetically sorted so I removed that.

Make the SLIST static

bapt accepted this revision.Sep 26 2017, 9:03 AM

This revision is now accepted and ready to land.Sep 26 2017, 9:03 AM

I've accepted this. As bapt@ noted, it loses the alphabetical order.
I don't know if that matters. I believe it means that the reply to
"showmount -e" will not be alphabetically ordered. Does any
client care? I don't know.

Closed by commit rS324257: mountd: Convert exportlist to SLIST (authored by manu). · Explain WhyOct 4 2017, 8:44 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

mountd/

mountd.c

42 lines

Diff 33435

View Options

mountd: Convert exportlist to SLISTClosedPublicActions