Page MenuHomeFreeBSD
Differential D12427

Update CMake to 3.9.3
ClosedPublic
Actions

Authored by adridg on Sep 20 2017, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 5:45 PM
Unknown Object (File)
Sun, Dec 8, 4:12 PM
Unknown Object (File)
Nov 5 2024, 11:25 PM
Unknown Object (File)
Nov 5 2024, 11:25 PM
Unknown Object (File)
Nov 5 2024, 11:25 PM
Unknown Object (File)
Nov 5 2024, 11:25 PM
Unknown Object (File)
Nov 5 2024, 11:25 PM
Unknown Object (File)
Nov 5 2024, 11:21 PM
View All Files
Subscribers
mat

Details

Reviewers
rakuco
tcberner
Commits
rP451050: Update CMake to 3.9.3
Summary

New release of CMake, now with latest boost detection.

Test Plan

Builds on 10.3 amd64. Needs an exp-run, anyway.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 11676
Build 12022: arc lint + arc unit

Event Timeline

adridg created this revision.Sep 20 2017, 8:10 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 20 2017, 8:10 PM
Harbormaster completed remote builds in B11644: Diff 33246.Sep 20 2017, 8:10 PM
rakuco requested changes to this revision.Sep 20 2017, 8:13 PM

You also need to update devel/cmake-doc and devel/cmake-gui.

This revision now requires changes to proceed.Sep 20 2017, 8:13 PM
adridg updated this revision to Diff 33264.Sep 21 2017, 2:00 PM

Also bump versions on -doc, -gui (untested)

Harbormaster completed remote builds in B11652: Diff 33264.Sep 21 2017, 2:00 PM
rakuco accepted this revision.Sep 21 2017, 2:03 PM

lgtm, but you must ask for an exp-run before landing.

This revision is now accepted and ready to land.Sep 21 2017, 2:03 PM
mat added inline comments.Sep 21 2017, 2:06 PM
devel/cmake/Makefile
5–6

You should add a comment before DISTVERSION saying "remember to update cmake-gui and cmake-doc"

adridg updated this revision to Diff 33307.Sep 22 2017, 10:10 AM

Drop patch that was introduced for ceph and Boost (PR 222207) because it
is included in CMake 3.9.3. Mark patch that was upstreamed for 3.10.
Update -doc and -gui.

This revision now requires review to proceed.Sep 22 2017, 10:10 AM
Harbormaster completed remote builds in B11676: Diff 33307.Sep 22 2017, 10:10 AM
adridg updated this revision to Diff 33308.Sep 22 2017, 10:15 AM

Take mat@'s suggestion and write note to self.

Harbormaster completed remote builds in B11677: Diff 33308.Sep 22 2017, 10:15 AM
adridg marked an inline comment as done.Sep 22 2017, 10:15 AM
rakuco requested changes to this revision.Sep 22 2017, 10:18 AM
rakuco added inline comments.
devel/cmake/Makefile
6

You need to drop PORTREVISION.

devel/cmake/files/patch-Modules_Platform_FreeBSD-CXX.cmake
3

Awesome!

This revision now requires changes to proceed.Sep 22 2017, 10:18 AM
adridg marked 2 inline comments as done.Sep 22 2017, 10:23 AM
adridg updated this revision to Diff 33309.Sep 22 2017, 10:23 AM

Remove PORTREVISION.

Harbormaster completed remote builds in B11678: Diff 33309.Sep 22 2017, 10:23 AM
rakuco accepted this revision.Sep 22 2017, 10:24 AM

shipit!
we just need an exp-run now

This revision is now accepted and ready to land.Sep 22 2017, 10:24 AM
tcberner accepted this revision.Oct 1 2017, 8:20 AM

exp-run results are in: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222513#c3
ship it.

Closed by commit rP451050: Update CMake to 3.9.3 (authored by adridg). · Explain WhyOct 1 2017, 4:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
cmake-doc/
2 lines
cmake-gui/
2 lines
cmake/
2 lines
6 lines
files/
3 lines

Diff 33307

View Options

devel/cmake-doc/Makefile

Loading...
View Options

devel/cmake-gui/Makefile

Loading...
View Options

devel/cmake/Makefile

Loading...
View Options

devel/cmake/distinfo

Loading...
View Options

devel/cmake/files/patch-Modules_Platform_FreeBSD-CXX.cmake

Loading...
View Options

devel/cmake/files/patch-git_ee1f8903

Loading...