Differential D12410

bnxt: Enable support to run as a guest driver on VF attached VM
ClosedPublic
Actions

Authored by siva.kallam_broadcom.com on Sep 19 2017, 4:57 AM.

Tags

None

Referenced Files

	F103820832: D12410.diff
	Fri, Nov 29, 9:18 PM

	Unknown Object (File)
	Thu, Nov 28, 8:15 AM

	Unknown Object (File)
	Tue, Nov 26, 12:48 PM

	Unknown Object (File)
	Thu, Nov 21, 2:01 PM

	Unknown Object (File)
	Wed, Nov 20, 12:44 PM

	Unknown Object (File)
	Fri, Nov 15, 7:49 AM

	Unknown Object (File)
	Tue, Nov 5, 10:59 PM

	Unknown Object (File)
	Oct 25 2024, 11:08 AM

View All 59 Files

Subscribers

Details

Reviewers

sbruno
shurd
bhargava.marreddy_broadcom.com
siva.kallam_broadcom.com

Commits

rS323874: bnxt: Fix driver when attached to a VF

Summary

Added support to issue HWRM_FUNC_VF_CFG if driver running with VF
Corrected logic to find VF or NPAR
Cleaned and Consolidated BNXT flags
Added additional check for WoL enable

Test Plan

Ran sanity tests as VF driver on both ESXi and Linux Hyper visors.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

siva.kallam_broadcom.com created this revision.Sep 19 2017, 4:57 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 19 2017, 4:57 AM

shurd added inline comments.Sep 19 2017, 7:14 AM

sys/dev/bnxt/bnxt_hwrm.c
953	Possibly this function should be renamed or split? The implication of bnxt_hwrm_func_cfg() is that it calls HWRM_FUNC_CFG. Maybe bnxt_cfg_async_cr()? Or split into bnxt_hwrm_func_cfg() and bnxt_hwrm_func_vf_cfg() and have the caller choose the correct function?

Comment in-line

siva.kallam_broadcom.com accepted this revision.Sep 19 2017, 8:57 AM

siva.kallam_broadcom.com added inline comments.

sys/dev/bnxt/bnxt_hwrm.c
953	OK. Will modify it as bnxt_cfg_async_cr().

This revision is now accepted and ready to land.Sep 19 2017, 8:57 AM

Renamed bnxt_hwrm_func_cfg to bnxt_cfg_async_cr as later one is more appropriate.

This revision now requires review to proceed.Sep 19 2017, 9:13 AM

Looks good to me.

This revision is now accepted and ready to land.Sep 19 2017, 5:02 PM

Since there's no real way to test this on FreeBSD at the moment ...

stlgtm

Closed by commit rS323874: bnxt: Fix driver when attached to a VF (authored by shurd). · Explain WhySep 21 2017, 8:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

bnxt/

9 lines

27 lines

2 lines

Diff 33211

sys/dev/bnxt/bnxt.h

Loading...

sys/dev/bnxt/bnxt_hwrm.c

Loading...

sys/dev/bnxt/if_bnxt.c

Loading...