Page MenuHomeFreeBSD
Differential D12361

Bring in bit operation functions, ala gawk.
ClosedPublic
Actions

Authored by imp on Sep 13 2017, 8:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 13, 3:00 PM
Unknown Object (File)
Wed, Nov 12, 3:48 PM
Unknown Object (File)
Tue, Nov 11, 11:32 PM
Unknown Object (File)
Sat, Nov 8, 11:53 AM
Unknown Object (File)
Sun, Nov 2, 10:26 AM
Unknown Object (File)
Sun, Nov 2, 10:26 AM
Unknown Object (File)
Sun, Nov 2, 10:26 AM
Unknown Object (File)
Sun, Nov 2, 10:26 AM
View All Files
Subscribers
jhb
pfg

Details

Reviewers
bapt
jhb
pfg
Commits
rS323577: Implement gawk multiple-arg extension to and, or, and xor.
rS323576: Bring in bit operation functions, ala gawk.
Summary

These are from OpenBSD:

Extend awk with bitwise operations. This is an extension to the awk
spec and documented as such, but comes in handy from time to time.
The prototypes make it compatible with a similar GNU awk extension.

ok millert@, enthusiasm from deraadt@

Obtained From: OpenBSD awk.h 1.12, lex.c 1.10, run.c 1.29

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11558
Build 11911: arc lint + arc unit

Event Timeline

imp created this revision.Sep 13 2017, 8:16 PM
Harbormaster completed remote builds in B11550: Diff 33039.Sep 13 2017, 8:16 PM
bapt accepted this revision.Sep 13 2017, 8:20 PM
This revision is now accepted and ready to land.Sep 13 2017, 8:20 PM
jhb accepted this revision.Sep 13 2017, 8:30 PM
jhb added a subscriber: jhb.

Thanks

pfg accepted this revision.Sep 13 2017, 8:35 PM
pfg added a subscriber: pfg.

Minor tab/space issues but otherwise looks fine. Thanks!

contrib/one-true-awk/awk.h
129

There should be TAB instead of space after the #define.

imp added a comment.EditedSep 14 2017, 3:31 AM
In D12361#256383, @pfg wrote:

Minor tab/space issues but otherwise looks fine. Thanks!

Thanks! Fixed. Won't re-upload unless there's other changes.

imp updated this revision to Diff 33049.Sep 14 2017, 3:35 AM

Minor tweaks: fix error messages and pendantic white space issues.

This revision now requires review to proceed.Sep 14 2017, 3:35 AM
imp marked an inline comment as done.Sep 14 2017, 3:38 AM
imp updated this revision to Diff 33052.Sep 14 2017, 4:42 AM

Implement the gawk aribtrary number args for and, or, and xor.

Harbormaster completed remote builds in B11556: Diff 33052.Sep 14 2017, 4:42 AM
imp updated this revision to Diff 33053.Sep 14 2017, 4:45 AM

Looks like someone s/0/NULL in the context of a pointer,
so make it look the same.

Harbormaster completed remote builds in B11557: Diff 33053.Sep 14 2017, 4:45 AM
imp updated this revision to Diff 33054.Sep 14 2017, 4:46 AM

back to master...

imp added a comment.Sep 14 2017, 4:47 AM

OK. All the bugs I found are fixed, and the gawk extensions are now implemented more fully. I intend to commit this, unless I hear otherwise.

bapt accepted this revision.Sep 14 2017, 4:51 AM
This revision is now accepted and ready to land.Sep 14 2017, 4:51 AM
pfg accepted this revision.Sep 14 2017, 5:11 AM
Closed by commit rS323576: Bring in bit operation functions, ala gawk. (authored by imp). · Explain WhySep 14 2017, 5:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
contrib/
one-true-awk/
6 lines
6 lines
72 lines
usr.bin/
awk/
15 lines

Diff 33054

View Options

contrib/one-true-awk/awk.h

Loading...
View Options

contrib/one-true-awk/lex.c

Loading...
View Options

contrib/one-true-awk/run.c

Loading...
View Options

usr.bin/awk/awk.1

Loading...