Differential D12364

Add PNP metadata to a few drivers
ClosedPublic
Actions

Authored by cem on Sep 14 2017, 2:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 28, 1:01 PM

	Unknown Object (File)
	Tue, Oct 22, 8:06 PM

	Unknown Object (File)
	Oct 9 2024, 7:10 AM

	Unknown Object (File)
	Oct 1 2024, 3:12 PM

	Unknown Object (File)
	Sep 30 2024, 1:48 PM

	Unknown Object (File)
	Sep 24 2024, 9:43 AM

	Unknown Object (File)
	Sep 24 2024, 5:11 AM

	Unknown Object (File)
	Sep 23 2024, 5:41 PM

View All 50 Files

Subscribers

None

Details

Reviewers

imp
emaste

Commits

rS323586: Add PNP metadata to a few drivers

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11554
Build 11907: arc lint + arc unit

Event Timeline

cem created this revision.Sep 14 2017, 2:41 AM

Harbormaster completed remote builds in B11553: Diff 33045.Sep 14 2017, 2:41 AM

imp added inline comments.Sep 14 2017, 3:17 AM

sys/dev/amdsmn/amdsmn.c
92	W16:vendor;W16:product I think is what you want here.
sys/dev/amdtemp/amdtemp.c
91	There's no need to make this change.... The old format would work just fine
170	Again, these changes aren't needed.

cem added inline comments.Sep 14 2017, 3:22 AM

sys/dev/amdsmn/amdsmn.c
92	Why? The type is a uint32 — wouldn't W16+W16 be wrong on big endian (not that AMD makes big endian CPUs, but still)?
sys/dev/amdtemp/amdtemp.c
91	Hm, for some reason I thought only the 32-bit form was supported. Will revert it.

Drop unneeded amdtemp changes.

imp added inline comments.Sep 14 2017, 4:56 AM

sys/dev/amdsmn/amdsmn.c
92	I just checked the source. The type is two 16-bit ints, consecutive in memory before your changes. So U16 is what you need instead of W16.
sys/dev/amdtemp/amdtemp.c
91	No, a lot of different types are supported...

cem added inline comments.Sep 14 2017, 5:09 AM

sys/dev/amdsmn/amdsmn.c
92	Are you sure you're looking at the right module? amdsmn uses a single uint32_t. I wrote it last week. (amdtemp, below, uses two consecutive 16 bit ints.)

Thanks for the changes. Now that my eyes are uncrossed, this looks sane to me now.

Thanks for doing this! We need more of it.

This revision is now accepted and ready to land.Sep 14 2017, 5:30 AM

Closed by commit rS323586: Add PNP metadata to a few drivers (authored by cem). · Explain WhySep 14 2017, 3:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

amdsmn/

2 lines

amdtemp/

5 lines

intpm/

52 lines

ioat/

7 lines

ntb/

ntb_hw/

9 lines

Diff 33048

sys/dev/amdsmn/amdsmn.c

Loading...

sys/dev/amdtemp/amdtemp.c

Loading...

sys/dev/intpm/intpm.c

Loading...

sys/dev/ioat/ioat.c

Loading...

sys/dev/ntb/ntb_hw/ntb_hw_intel.c

Loading...