Page MenuHomeFreeBSD
Differential D12287

loader.efi: chain loader should provide proper device handle
ClosedPublic
Actions

Authored by tsoome on Sep 9 2017, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 5:22 PM
Unknown Object (File)
Thu, Dec 5, 5:17 AM
Unknown Object (File)
Mon, Dec 2, 8:50 PM
Unknown Object (File)
Mon, Dec 2, 9:57 AM
Unknown Object (File)
Nov 25 2024, 1:22 AM
Unknown Object (File)
Nov 11 2024, 12:04 AM
Unknown Object (File)
Nov 10 2024, 5:33 AM
Unknown Object (File)
Oct 15 2024, 12:29 PM
View All 68 Files
Subscribers
sylvain_sylvaingarrigues.com

Details

Reviewers
imp
allanjude
Commits
rS323389: loader.efi: chain loader should provide proper device handle
Summary

Since the efipart rewrite, the chain command was looking for device
handle using interface applicable only for net devices. Disk
partitions and zfs pools need their own approach to find the proper handle.

Test Plan

tested by chain loading loader.efi from another zfs pool and from ESP.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tsoome created this revision.Sep 9 2017, 11:48 AM
imp accepted this revision.Sep 9 2017, 5:57 PM

This looks good to me.

This revision is now accepted and ready to land.Sep 9 2017, 5:57 PM
Closed by commit rS323389: loader.efi: chain loader should provide proper device handle (authored by tsoome). · Explain WhySep 10 2017, 1:53 PM
This revision was automatically updated to reflect the committed changes.
sylvain_sylvaingarrigues.com added a subscriber: sylvain_sylvaingarrigues.com.Sep 11 2017, 6:25 AM

This breaks the kernel build if WITHOUT_ZFS is defined in src.conf.

Revision Contents
Changeset List

PathSize
head/
sys/
boot/
efi/
include/
1 line
1 line
libefi/
71 lines
13 lines
loader/
38 lines

Diff 32876

View Options

head/sys/boot/efi/include/efilib.h

Loading...
View Options

head/sys/boot/efi/include/efizfs.h

Loading...
View Options

head/sys/boot/efi/libefi/efipart.c

Loading...
View Options

head/sys/boot/efi/libefi/efizfs.c

Loading...
View Options

head/sys/boot/efi/loader/main.c

Loading...