Page MenuHomeFreeBSD
Differential D12267

Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has been destroyed before its tcptw with INVARIANTS undefined.
ClosedPublic
Actions

Authored by jch on Sep 7 2017, 3:12 PM.
Tags
None
Referenced Files
F171980462: D12267.diff
Tue, Sep 15, 2:58 AM
Unknown Object (File)
Thu, Sep 10, 6:31 AM
Unknown Object (File)
Mon, Sep 7, 5:12 PM
Unknown Object (File)
Thu, Sep 3, 11:08 AM
Unknown Object (File)
Wed, Sep 2, 9:12 AM
Unknown Object (File)
Sun, Aug 30, 9:54 AM
Unknown Object (File)
Wed, Aug 26, 12:54 AM
Unknown Object (File)
Sun, Aug 23, 3:23 PM
View All Files
Subscribers
j-nitrology.com
kbowling
mjoras

Details

Reviewers
• hselasky
mjoras
Group Reviewers
transport
Commits
rS324948: MFC r324179, r324193:
rS324179: Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has
Summary

Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has been destroyed before its tcptw wint INVARIANTS undefined.

This is a symmetric change of r307551:

A INP_TIMEWAIT inp should not be destroyed before its tcptw, and INVARIANTS
will catch this case. If INVARIANTS is undefined it will emit a log(LOG_ERR)
and avoid a hard to debug infinite loop in tcp_tw_2msl_scan().

Reported by: Ben Rubson, hselasky
Submitted by: hselasky
Tested by: Ben Rubson, jch
MFC after: 1 week
Sponsored by: Verisign, inc

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11413
Build 11773: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
netinet/
27 lines

Diff 32766

View Options

sys/netinet/tcp_timewait.c

Loading...