Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has been destroyed before its tcptw with INVARIANTS undefined.
ClosedPublic
Actions

Authored by jch on Sep 7 2017, 3:12 PM.

Details

Reviewers

• hselasky
mjoras

Group Reviewers

transport

Commits

rS324948: MFC r324179, r324193:
rS324179: Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has

Summary

Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has been destroyed before its tcptw wint INVARIANTS undefined.

This is a symmetric change of r307551:

A INP_TIMEWAIT inp should not be destroyed before its tcptw, and INVARIANTS
will catch this case. If INVARIANTS is undefined it will emit a log(LOG_ERR)
and avoid a hard to debug infinite loop in tcp_tw_2msl_scan().

Reported by: Ben Rubson, hselasky
Submitted by: hselasky
Tested by: Ben Rubson, jch
MFC after: 1 week
Sponsored by: Verisign, inc

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11413
Build 11773: arc lint + arc unit

Event Timeline

jch created this revision.Sep 7 2017, 3:12 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 7 2017, 3:12 PM

• hselasky accepted this revision.Sep 7 2017, 4:44 PM

j-nitrology.com added a subscriber: j-nitrology.com.Sep 8 2017, 12:26 AM

For anyone wondering about the history here, see this thread from -net: https://lists.freebsd.org/pipermail/freebsd-net/2017-August/048621.html. TL;DR is this: https://lists.freebsd.org/pipermail/freebsd-net/2017-September/048826.html

This revision is now accepted and ready to land.Sep 12 2017, 4:41 PM

kbowling added a subscriber: kbowling.Sep 12 2017, 8:07 PM

Closed by commit rS324179: Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has (authored by jch). · Explain WhyOct 1 2017, 9:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_timewait.c

27 lines

Diff 32766

View Options

sys/netinet/tcp_timewait.c

Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has been destroyed before its tcptw with INVARIANTS undefined.ClosedPublicActions