Page MenuHomeFreeBSD

crunchgen: quiet -Wmissing-prototypes
ClosedPublic

Authored by rlibby on Aug 23 2017, 7:54 AM.
Tags
None
Referenced Files
F108923375: D12107.diff
Wed, Jan 29, 3:01 PM
F108892237: D12107.id.diff
Wed, Jan 29, 5:27 AM
Unknown Object (File)
Tue, Jan 28, 10:06 AM
Unknown Object (File)
Mon, Jan 27, 12:50 AM
Unknown Object (File)
Fri, Jan 24, 10:21 PM
Unknown Object (File)
Wed, Jan 1, 6:02 AM
Unknown Object (File)
Dec 27 2024, 12:47 PM
Unknown Object (File)
Dec 8 2024, 2:47 AM
Subscribers

Details

Test Plan
buildworld; installworld
/rescue/rescue (usage)
/rescue/rescue foo (usage)
/rescue/rescue ls

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11250
Build 11626: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 26 2017, 3:04 PM
usr.sbin/crunch/crunchgen/crunchgen.c
1108

Whoops, that extra "\n" led to the following makefile template, from strings $(which crunchgen):

%s_stub.c:
        echo "extern int main(int argc, char **argv, char **envp);
int _crunched_%s_stub(int argc, char **argv, char **envp){return main(argc,argv,envp);}" >%s_stub.c
%s.lo: %s_stub.o $(%s_OBJPATHS)

I didn't notice earlier, apparently the build is using the installed crunchgen (rather than the one being built)?

New version replaces the line feed with a space and gives this from
strings /usr/obj/usr/src/freebsd/usr.sbin/crunch/crunchgen/crunchgen:

%s_stub.c:
        echo "extern int main(int argc, char **argv, char **envp); int _crunched_%s_stub(int argc, char **argv, char **envp){return main(argc,argv,envp);}" >%s_stub.c
%s.lo: %s_stub.o $(%s_OBJPATHS)
rlibby edited edge metadata.

Keep generated stub on one line.

This revision now requires review to proceed.Aug 26 2017, 11:24 PM
This revision was automatically updated to reflect the committed changes.