Page MenuHomeFreeBSD

crunchgen: quiet -Wmissing-prototypes
ClosedPublic

Authored by rlibby on Aug 23 2017, 7:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 26 2024, 6:08 PM
Unknown Object (File)
Oct 17 2024, 4:57 AM
Unknown Object (File)
Oct 3 2024, 8:41 PM
Unknown Object (File)
Oct 3 2024, 2:22 PM
Unknown Object (File)
Oct 1 2024, 5:02 PM
Unknown Object (File)
Oct 1 2024, 2:25 PM
Unknown Object (File)
Sep 28 2024, 6:05 PM
Unknown Object (File)
Sep 28 2024, 9:31 AM
Subscribers

Details

Test Plan
buildworld; installworld
/rescue/rescue (usage)
/rescue/rescue foo (usage)
/rescue/rescue ls

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11207
Build 11585: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 26 2017, 3:04 PM
usr.sbin/crunch/crunchgen/crunchgen.c
1108

Whoops, that extra "\n" led to the following makefile template, from strings $(which crunchgen):

%s_stub.c:
        echo "extern int main(int argc, char **argv, char **envp);
int _crunched_%s_stub(int argc, char **argv, char **envp){return main(argc,argv,envp);}" >%s_stub.c
%s.lo: %s_stub.o $(%s_OBJPATHS)

I didn't notice earlier, apparently the build is using the installed crunchgen (rather than the one being built)?

New version replaces the line feed with a space and gives this from
strings /usr/obj/usr/src/freebsd/usr.sbin/crunch/crunchgen/crunchgen:

%s_stub.c:
        echo "extern int main(int argc, char **argv, char **envp); int _crunched_%s_stub(int argc, char **argv, char **envp){return main(argc,argv,envp);}" >%s_stub.c
%s.lo: %s_stub.o $(%s_OBJPATHS)
rlibby edited edge metadata.

Keep generated stub on one line.

This revision now requires review to proceed.Aug 26 2017, 11:24 PM
This revision was automatically updated to reflect the committed changes.