Add py-topoosort and py3-toposort.
ClosedPublic
Actions

Authored by ed on Aug 16 2017, 3:36 PM.

Details

Reviewers

koobs
wg
mat

Commits

rP448060: Add py-toposort.

Summary

I am currently in the process of creating ports for various components
related to CloudABI, including ARPC (an RPC framework that supports file
descriptor passing) and Flower (a capability-based network backplane).

The former comes with a script called 'aprotoc' for creating C++
bindings for messages and RPC services. This script depends on Python's
toposort package to order declarations in the resulting C++ header file,
taking dependencies into account.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 11105
Build 11487: arc lint + arc unit

Event Timeline

ed created this revision.Aug 16 2017, 3:36 PM

Herald added a subscriber: mat. · View Herald TranscriptAug 16 2017, 3:36 PM

Revert premature change to devel/Makefile.

Harbormaster completed remote builds in B11105: Diff 32122.Aug 16 2017, 3:38 PM

Add a proper pkg-descr.

Sorry for the noise.

Harbormaster completed remote builds in B11106: Diff 32123.Aug 16 2017, 3:39 PM

LGTM

mat accepted this revision.Aug 16 2017, 3:47 PM

This revision is now accepted and ready to land.Aug 16 2017, 3:47 PM

Closed by commit rP448060: Add py-toposort. (authored by ed). · Explain WhyAug 16 2017, 3:56 PM

This revision was automatically updated to reflect the committed changes.

Wow! Thanks for reviewing this change so quickly!

When I tried committing this, I got an error message, regarding py3-* ports being deprecated in favour of FLAVORS support. I've removed the py3-toposort port from this change and went ahead committing this.

Adding py3-* ports requires an Approved by: portmgr (user) line in the commit (to bypass the pre-commit gate)

Mat is a member of portmgr though its not explicit with what hat he accepted (assume not portmgr unless explicit)

If you need py3-toposort as a dependency for another port that uses it (and builds with Python 3.x), just create a new review and add portmgr (Blocking) to reviewers