Fix vt(4)'s response to Device Status Report escape sequences
Needs ReviewPublic
Actions

Authored by guest-svmhdvn on Aug 7 2017, 8:38 PM.

Details

Reviewers

emaste
ray

Summary

Fixes bug 220507.

Libteken would correctly compute the cursor position for a CPR escape sequence ("[6n"), but wouldn't write it back to the TTY device.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

guest-svmhdvn created this revision.Aug 7 2017, 8:38 PM

guest-svmhdvn edited the summary of this revision. (Show Details)Aug 7 2017, 8:45 PM

guest-svmhdvn added reviewers: emaste, ray.

emaste added a reviewer: ed.Aug 7 2017, 11:31 PM

The problem with this change is that I'm not 100% sure this won't cause an infinite amount of recursion in the TTY layer. Basically, this is what's happening:

Write to TTY -> Write to struct terminal -> Processed by libteken -> Result pushed back into the TTY.

But what if the TTY has echoing enabled? The response will be pushed through the terminal layer once more.

For this to work, we'll need to introduce another version of rint() that is guaranteed to ignore echoing. Alternatively, we should add a callout/taskqueue/... to push the response back into the TTY layer asynchronously.

Add a check for the maximum history size. This maximum is set to the same value as the maximum in syscons(4).
Fix the error string on a negative number argument