Add missing header to shmget(2)
ClosedPublic
Actions

Authored by sevan on Aug 12 2017, 4:25 PM.

Details

Reviewers

Group Reviewers

Src Committers
manpages

Commits

rS322432: Add missing header.

Summary

S_IRUSR is defined in sys/stat.h

Bug 209229
mt@markoturk.info

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sevan created this revision.Aug 12 2017, 4:25 PM

Herald added a reviewer: manpages. · View Herald TranscriptAug 12 2017, 4:25 PM

Herald added a subscriber: imp. · View Herald Transcript

OK, go ahead with this.

This revision is now accepted and ready to land.Aug 12 2017, 4:39 PM

Closed by commit rS322432: Add missing header. (authored by sevan). · Explain WhyAug 12 2017, 5:47 PM

This revision was automatically updated to reflect the committed changes.

This is internally consistent, but does not match what POSIX says. POSIX says only <sys/shm.h> is required and the permissions should be coded using octal constants (yuck). However, if a programmer wants to use S_IRUSR and the like, that is fine. POSIX defines the exact values these constants should have. I don't think POSIX needs to be followed exactly in this.

Note that <sys/ipc.h> can safely be removed from this list. POSIX says <sys/shm.h> should include <sys/ipc.h> and that is what we implement.

Also, it seems like <sys/types.h> can be removed. A shmget() invocation will compile and run with only #include <sys/shm.h>.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

sys/

shmget.2

3 lines

Diff 31993

View Options

head/lib/libc/sys/shmget.2

Add missing header to shmget(2)ClosedPublicActions