Differential D11951

www/nginx-devel: Update from 1.13.3 to 1.13.4
ClosedPublic
Actions

Authored by joneum on Aug 10 2017, 11:53 AM.

Details

Reviewers

tz
rene
miwi

Commits

rP448173: MFH: r447740
rP447740: - www/nginx-devel: Update from 1.13.3 to 1.13.4

Summary

www/nginx-devel: Update from 1.13.3 to 1.13.4
pet Portlint

Changelog: *) Feature: the ngx_http_mirror_module.

*) Bugfix: client connections might be dropped during configuration testing when using the "reuseport" parameter of the "listen" directive on Linux.

*) Bugfix: request body might not be available in subrequests if it was saved to a file and proxying was used.

*) Bugfix: cleaning cache based on the "max_size" parameter did not work on Windows.

*) Bugfix: any shared memory allocation required 4096 bytes on Windows.

*) Bugfix: nginx worker might be terminated abnormally when using the "zone" directive inside the "upstream" block on Windows.

Approved by: osa (maintainer)
Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

osa informed via eMail

~/dev/ports/www/nginx-devel % portlint -AC
WARN: Makefile: HTTP_ACCESSKEY appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE.
WARN: Makefile: HTTP_ACCESSKEY appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE.
WARN: Makefile: [495]: is USE_HTTP_DAV a user-settable option? Consider using WITH_HTTP_DAV instead.
WARN: Makefile: [909]: is USE_HTTP_REWRITE a user-settable option? Consider using WITH_HTTP_REWRITE instead.
WARN: Makefile: [1126]: is USE_HTTP_SSL a user-settable option? Consider using WITH_HTTP_SSL instead.
WARN: Makefile: [452]: IGNORE messages should begin with a lowercase letter and end without a period.
WARN: Makefile: [299]: possible direct use of command "strip" found. use ${STRIP_CMD} instead.
WARN: Makefile: possible use of absolute pathname "/var".
WARN: Makefile: possible use of absolute pathname "/etc/make.conf".
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX.
WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them.
0 fatal errors and 14 warnings found.

poudriere testport:

10.3-amd64
10.3-i386
11.1-amd64
11.1-i386
12.0-CURRENT r321899 amd64
12.0-CURRENT r321913 i386

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joneum created this revision.Aug 10 2017, 11:53 AM

Herald added a subscriber: mat. · View Herald TranscriptAug 10 2017, 11:53 AM

Harbormaster completed remote builds in B10997: Diff 31862.Aug 10 2017, 11:53 AM

mat added inline comments.Aug 10 2017, 12:45 PM

www/nginx-devel/Makefile
470–473 ↗	(On Diff #31862)	One day, you should try to compress all those entries in a single line, here: FASTDFS_GH_TUPLE= happyfish100:fastdfs-nginx-module:5a8110f:fastdfs
474–481 ↗	(On Diff #31862)	and use options helpers: FASTDFS_EXTRA_PATCHES= blah FASTDFS_BUILD_DEPENDS= blurp FASTDFS_LIB_DEPENDS= bar FASTDFS_CONFIGURE_ON= baz

joneum added inline comments.Aug 10 2017, 12:49 PM

www/nginx-devel/Makefile
470–473 ↗	(On Diff #31862)	nginx-devel is the port from osa. But, you're right, the Makefile is verry big. I think, to switch all GitHubs to GH_TUPLE is a project for the future.